diff options
author | Thomas Martitz <kugel@rockbox.org> | 2010-05-06 17:35:13 +0000 |
---|---|---|
committer | Thomas Martitz <kugel@rockbox.org> | 2010-05-06 17:35:13 +0000 |
commit | 0a1d7c28b7e9da555d26d489cde2da26e2cc9ca0 (patch) | |
tree | a21521e6e4b8fe0131c4d9e8bae6d8cc78125fe9 /firmware/common | |
parent | c61e89c0eda126c2c1a4a3983520c35fe30db156 (diff) | |
download | rockbox-0a1d7c28b7e9da555d26d489cde2da26e2cc9ca0.tar.gz rockbox-0a1d7c28b7e9da555d26d489cde2da26e2cc9ca0.zip |
Make open() posix compliant api-wise. A few calls (those with O_CREAT) need the additional optional mode parameter so add it. Impact for the core is almost zero, as open() is a wrapper macro for the real open function which doesn't take the variable parameter.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25844 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'firmware/common')
-rw-r--r-- | firmware/common/dircache.c | 2 | ||||
-rw-r--r-- | firmware/common/file.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/firmware/common/dircache.c b/firmware/common/dircache.c index 495366f5d8..225ed1aff1 100644 --- a/firmware/common/dircache.c +++ b/firmware/common/dircache.c | |||
@@ -557,7 +557,7 @@ int dircache_save(void) | |||
557 | return -1; | 557 | return -1; |
558 | 558 | ||
559 | logf("Saving directory cache"); | 559 | logf("Saving directory cache"); |
560 | fd = open(DIRCACHE_FILE, O_WRONLY | O_CREAT | O_TRUNC); | 560 | fd = open(DIRCACHE_FILE, O_WRONLY | O_CREAT | O_TRUNC, 0666); |
561 | 561 | ||
562 | maindata.magic = DIRCACHE_MAGIC; | 562 | maindata.magic = DIRCACHE_MAGIC; |
563 | maindata.size = dircache_size; | 563 | maindata.size = dircache_size; |
diff --git a/firmware/common/file.c b/firmware/common/file.c index 05612cd75e..438a7106ca 100644 --- a/firmware/common/file.c +++ b/firmware/common/file.c | |||
@@ -57,7 +57,7 @@ static int flush_cache(int fd); | |||
57 | 57 | ||
58 | int file_creat(const char *pathname) | 58 | int file_creat(const char *pathname) |
59 | { | 59 | { |
60 | return open(pathname, O_WRONLY|O_CREAT|O_TRUNC); | 60 | return open(pathname, O_WRONLY|O_CREAT|O_TRUNC, 0666); |
61 | } | 61 | } |
62 | 62 | ||
63 | static int open_internal(const char* pathname, int flags, bool use_cache) | 63 | static int open_internal(const char* pathname, int flags, bool use_cache) |
@@ -228,7 +228,7 @@ static int open_internal(const char* pathname, int flags, bool use_cache) | |||
228 | return fd; | 228 | return fd; |
229 | } | 229 | } |
230 | 230 | ||
231 | int open(const char* pathname, int flags) | 231 | int file_open(const char* pathname, int flags) |
232 | { | 232 | { |
233 | /* By default, use the dircache if available. */ | 233 | /* By default, use the dircache if available. */ |
234 | return open_internal(pathname, flags, true); | 234 | return open_internal(pathname, flags, true); |