Move screendump from apps to firmware, solving two nasty firmware-to-apps calls. This required to move the filename creation functions as well. * Fix bug in the BMP header of Clip screendumps. * Add remote screendump for targets with an LCD remote. * Simplify some ifdefs and rename a macro in the sim.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19967 a1c6a512-1295-4272-9138-f99709370657

1 files changed, 6 insertions, 4 deletions

diff --git a/firmware/backlight.c b/firmware/backlight.c
index 9c153e885a..513f643171 100644
--- a/firmware/backlight.c
+++ b/firmware/backlight.c
@@ -35,6 +35,7 @@
 #include "timer.h"
 #include "backlight.h"
 #include "lcd.h"
+#include "screendump.h"
 
 #ifdef HAVE_REMOTE_LCD
 #include "lcd-remote.h"
@@ -57,9 +58,6 @@ int backlight_brightness = DEFAULT_BRIGHTNESS_SETTING;
 #include "backlight-sw-fading.h"
 #endif
 #ifdef SIMULATOR
-/* TODO: find a better way to do it but we need a kernel thread somewhere to
-   handle this */
-extern void screen_dump(void);
 
 static inline void _backlight_on(void)
 {
@@ -600,9 +598,13 @@ void backlight_thread(void)
 #endif /* HAVE_REMOTE_LCD/ HAVE_REMOTE_LCD_AS_MAIN */
 #endif /* !SIMULATOR */
 #ifdef SIMULATOR
-            /* This one here too for lack of a better place */
+            /* TODO: find a better way to do it but we need
+             * a kernel thread somewhere to handle this */
             case SYS_SCREENDUMP:
                 screen_dump();
+#ifdef HAVE_REMOTE_LCD
+                remote_screen_dump();
+#endif
                 break;
 #endif
             case SYS_USB_CONNECTED: