diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2022-09-20 13:27:51 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2022-10-05 11:23:11 -0400 |
commit | e57b4f909901ccc04b596ea817a98100b5f7b33b (patch) | |
tree | 1f391a6f2a9621be282234c5d053de6fa264e6bd /apps | |
parent | 1c5a0497cf7735009b26dd0da82ea2820a2486a2 (diff) | |
download | rockbox-e57b4f909901ccc04b596ea817a98100b5f7b33b.tar.gz rockbox-e57b4f909901ccc04b596ea817a98100b5f7b33b.zip |
gui: Remove gui_synclist_item_is_onscreen()
Only the "Rockbox Info" screen uses it for a rather silly purpose,
so remove the function. This helps to decouple things from the GUI.
Change-Id: Icf73e3ee1230c75bf43016c0f1c05c7fe1a24895
Diffstat (limited to 'apps')
-rw-r--r-- | apps/gui/list.c | 7 | ||||
-rw-r--r-- | apps/gui/list.h | 2 | ||||
-rw-r--r-- | apps/menus/main_menu.c | 3 |
3 files changed, 1 insertions, 11 deletions
diff --git a/apps/gui/list.c b/apps/gui/list.c index bb5d1a922e..d15948e97a 100644 --- a/apps/gui/list.c +++ b/apps/gui/list.c | |||
@@ -800,13 +800,6 @@ bool list_do_action(int context, int timeout, | |||
800 | return gui_synclist_do_button(lists, action); | 800 | return gui_synclist_do_button(lists, action); |
801 | } | 801 | } |
802 | 802 | ||
803 | bool gui_synclist_item_is_onscreen(struct gui_synclist *lists, | ||
804 | enum screen_type screen, int item) | ||
805 | { | ||
806 | int nb_lines = list_get_nb_lines(lists, screen); | ||
807 | return (unsigned)(item - lists->start_item[screen]) < (unsigned) nb_lines; | ||
808 | } | ||
809 | |||
810 | /* Simple use list implementation */ | 803 | /* Simple use list implementation */ |
811 | static int simplelist_line_count = 0, simplelist_line_remaining; | 804 | static int simplelist_line_count = 0, simplelist_line_remaining; |
812 | static int simplelist_line_pos; | 805 | static int simplelist_line_pos; |
diff --git a/apps/gui/list.h b/apps/gui/list.h index b716d8afd9..ede62d7b0a 100644 --- a/apps/gui/list.h +++ b/apps/gui/list.h | |||
@@ -220,8 +220,6 @@ extern void gui_synclist_add_item(struct gui_synclist * lists); | |||
220 | extern void gui_synclist_del_item(struct gui_synclist * lists); | 220 | extern void gui_synclist_del_item(struct gui_synclist * lists); |
221 | extern void gui_synclist_set_title(struct gui_synclist * lists, const char * title, | 221 | extern void gui_synclist_set_title(struct gui_synclist * lists, const char * title, |
222 | enum themable_icons icon); | 222 | enum themable_icons icon); |
223 | extern bool gui_synclist_item_is_onscreen(struct gui_synclist *lists, | ||
224 | enum screen_type screen, int item); | ||
225 | 223 | ||
226 | extern bool gui_synclist_keyclick_callback(int action, void* data); | 224 | extern bool gui_synclist_keyclick_callback(int action, void* data); |
227 | /* | 225 | /* |
diff --git a/apps/menus/main_menu.c b/apps/menus/main_menu.c index 2814c44fe6..03873faac9 100644 --- a/apps/menus/main_menu.c +++ b/apps/menus/main_menu.c | |||
@@ -441,8 +441,7 @@ static int info_action_callback(int action, struct gui_synclist *lists) | |||
441 | else if (action == ACTION_NONE) | 441 | else if (action == ACTION_NONE) |
442 | { | 442 | { |
443 | static int last_redraw = 0; | 443 | static int last_redraw = 0; |
444 | if (gui_synclist_item_is_onscreen(lists, 0, INFO_TIME) | 444 | if (TIME_AFTER(current_tick, last_redraw + HZ*5)) |
445 | && TIME_AFTER(current_tick, last_redraw + HZ*5)) | ||
446 | { | 445 | { |
447 | last_redraw = current_tick; | 446 | last_redraw = current_tick; |
448 | return ACTION_REDRAW; | 447 | return ACTION_REDRAW; |