diff options
author | Michael Hohmuth <sideral@rockbox.org> | 2011-08-04 12:13:16 +0000 |
---|---|---|
committer | Michael Hohmuth <sideral@rockbox.org> | 2011-08-04 12:13:16 +0000 |
commit | 3049a6bd04fdc4865de792adfc8b5474ef07b660 (patch) | |
tree | 10a7a4e0d87a291358ea31ff7a86cc80cb9c5f01 /apps | |
parent | 6196925915f28d3a5fac2f00c2e83d4fb8714ab5 (diff) | |
download | rockbox-3049a6bd04fdc4865de792adfc8b5474ef07b660.tar.gz rockbox-3049a6bd04fdc4865de792adfc8b5474ef07b660.zip |
Database: Fixed a potential buffer overrun in format_str. From
FS#12132 patch 8.
git-svn-id: svn://svn.rockbox.org/rockbox/branches/v3_9@30252 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps')
-rw-r--r-- | apps/tagtree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/tagtree.c b/apps/tagtree.c index 4003087133..df747a4b78 100644 --- a/apps/tagtree.c +++ b/apps/tagtree.c | |||
@@ -1129,7 +1129,7 @@ static int format_str(struct tagcache_search *tcs, struct display_format *fmt, | |||
1129 | 1129 | ||
1130 | buf[buf_pos++] = fmt->formatstr[i]; | 1130 | buf[buf_pos++] = fmt->formatstr[i]; |
1131 | 1131 | ||
1132 | if (buf_pos - 1 >= buf_size) | 1132 | if (buf_pos >= buf_size - 1) /* need at least one more byte for \0 */ |
1133 | { | 1133 | { |
1134 | logf("buffer overflow"); | 1134 | logf("buffer overflow"); |
1135 | return -4; | 1135 | return -4; |