summaryrefslogtreecommitdiff
path: root/apps/talk.c
diff options
context:
space:
mode:
authorJens Arnold <amiconn@rockbox.org>2004-11-18 20:19:40 +0000
committerJens Arnold <amiconn@rockbox.org>2004-11-18 20:19:40 +0000
commitfee06d68c777c71c0c38a359a1dcffc9ef30f17c (patch)
tree9527f261ce40dbba4fd3be8247ae132b1ed66763 /apps/talk.c
parent24e6dffa50ce702034185e1df6bdd238b3cf21ce (diff)
downloadrockbox-fee06d68c777c71c0c38a359a1dcffc9ef30f17c.tar.gz
rockbox-fee06d68c777c71c0c38a359a1dcffc9ef30f17c.zip
Bug fix: First dereference, then subscript, instead of vice versa. The old code never stored the correct header, and even caused NULL pointer accesses.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5424 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/talk.c')
-rw-r--r--apps/talk.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/apps/talk.c b/apps/talk.c
index 09d1727571..3dda67a040 100644
--- a/apps/talk.c
+++ b/apps/talk.c
@@ -211,9 +211,9 @@ static void mp3_callback(unsigned char** start, int* size)
211 sent = MIN(queue[queue_read].len, 0xFFFF); 211 sent = MIN(queue[queue_read].len, 0xFFFF);
212 *start = p_lastclip = queue[queue_read].buf; 212 *start = p_lastclip = queue[queue_read].buf;
213 *size = sent; 213 *size = sent;
214 curr_hd[0] = *start[1]; 214 curr_hd[0] = (*start)[1];
215 curr_hd[1] = *start[2]; 215 curr_hd[1] = (*start)[2];
216 curr_hd[2] = *start[3]; 216 curr_hd[2] = (*start)[3];
217 } 217 }
218 else if (silence_add && p_silence != NULL /* want and can add silence */ 218 else if (silence_add && p_silence != NULL /* want and can add silence */
219 && p_lastclip < p_thumbnail) /* and wasn't playing thumbnail file */ 219 && p_lastclip < p_thumbnail) /* and wasn't playing thumbnail file */