events: Rework event subsystem (add_event, send_event) to be more versatile.

add_event_ex is added that takes an extra user_data pointer. This pointer is
passed to the callback (add_event and add_event_ex have slightly different
callbacks types). All callbacks also get the event id passed. Events added
with add_event_ex must be removed with remove_event_ex because the user_data
pointer must match in addition to the callback pointer.

On the other add_event is simplified to omit the oneshort parameter which
was almost always false (still there with add_event_ex).

As a side effect the ata_idle_notify callbacks are changed as well, they
do not take a data parameter anymore which was always NULL anyway.

This commit also adds some documentation to events.h

Change-Id: I13e29a0f88ef908f175b376d83550f9e0231f772

1 files changed, 2 insertions, 3 deletions

diff --git a/apps/shortcuts.c b/apps/shortcuts.c
index ee8454485d..a9ae8248f1 100644
--- a/apps/shortcuts.c
+++ b/apps/shortcuts.c
@@ -184,9 +184,8 @@ static void init_shortcut(struct shortcut* sc)
 
 static int first_idx_to_writeback = -1;
 static bool overwrite_shortcuts = false;
-static void shortcuts_ata_idle_callback(void* data)
+static void shortcuts_ata_idle_callback(void)
 {
-    (void)data;
     int fd;
     char buf[MAX_PATH];
     int current_idx = first_idx_to_writeback;
@@ -387,7 +386,7 @@ static int shortcut_menu_get_action(int action, struct gui_synclist *lists)
             gui_synclist_select_item(lists, shortcut_count - 1);
         first_idx_to_writeback = 0;
         overwrite_shortcuts = true;
-        shortcuts_ata_idle_callback(NULL);
+        shortcuts_ata_idle_callback();
         if (shortcut_count == 0)
             return ACTION_STD_CANCEL;
         return ACTION_REDRAW;