Make the formatter functions used by the settings return a pointer to avoid usless copying of lang strings, this brought with it a long chain of const correctness and a few random cleanups

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22440 a1c6a512-1295-4272-9138-f99709370657

1 files changed, 2 insertions, 2 deletions

diff --git a/apps/settings_list.h b/apps/settings_list.h
index 1bc529c7d9..9f1805f169 100644
--- a/apps/settings_list.h
+++ b/apps/settings_list.h
@@ -73,7 +73,7 @@ struct int_setting {
     int min;
     int max;
     int step;
-    void (*formatter)(char*, size_t, int, const char*);
+    const char* (*formatter)(char*, size_t, int, const char*);
     int32_t (*get_talk_id)(int, int);
 };
 #define F_INT_SETTING 0x80
@@ -92,7 +92,7 @@ struct choice_setting {
                                
 struct table_setting {
     void (*option_callback)(int);
-    void (*formatter)(char*, size_t, int, const char*);
+    const char* (*formatter)(char*, size_t, int, const char*);
     int32_t (*get_talk_id)(int, int);
     int unit;
     int count;