diff options
author | William Wilgus <wilgus.william@gmail.com> | 2024-07-05 17:13:10 -0400 |
---|---|---|
committer | William Wilgus <me.theuser@yahoo.com> | 2024-07-09 01:40:02 -0400 |
commit | fdbaf7df597b404be04cecbdc83dbc0551a5b996 (patch) | |
tree | f4254d2ed63ce1174d9710a315678aeaf921399b /apps/settings_list.c | |
parent | 07cf87419189f8730eff53bb74669856a42a2016 (diff) | |
download | rockbox-fdbaf7df597b404be04cecbdc83dbc0551a5b996.tar.gz rockbox-fdbaf7df597b404be04cecbdc83dbc0551a5b996.zip |
[Feature] playlist_viewer id3 title display
Not sure this is a great idea from disk and battery standpoint
but there is no reason you can't..
using the name buffer to fill title data
prevent hitting the disk for each screen scroll
add get_metadata_ex to allow flags
METADATA_EXCLUDE_ID3_PATH
prevent copying the filename to the ID3 struct
METADATA_CLOSE_FD_ON_EXIT
instead of seeking to the beginning the file is closed before
get_metadata returns
add logic to allow a invalid fd to signal that get_metadata
should open and close the file within its call
bugfix per Chris_s don't use the tagcache for the trackinfo
Change-Id: Ic7a595b39a8d7a57f975312bc9c8bb4111f22a88
Diffstat (limited to 'apps/settings_list.c')
-rw-r--r-- | apps/settings_list.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/apps/settings_list.c b/apps/settings_list.c index 09a45f1faa..60a2735e90 100644 --- a/apps/settings_list.c +++ b/apps/settings_list.c | |||
@@ -1415,9 +1415,9 @@ const struct settings_list settings[] = { | |||
1415 | OFFON_SETTING(0,playlist_viewer_indices,LANG_SHOW_INDICES,true, | 1415 | OFFON_SETTING(0,playlist_viewer_indices,LANG_SHOW_INDICES,true, |
1416 | "playlist viewer indices",NULL), | 1416 | "playlist viewer indices",NULL), |
1417 | CHOICE_SETTING(0, playlist_viewer_track_display, LANG_TRACK_DISPLAY, 0, | 1417 | CHOICE_SETTING(0, playlist_viewer_track_display, LANG_TRACK_DISPLAY, 0, |
1418 | "playlist viewer track display","track name,full path", | 1418 | "playlist viewer track display","track name,full path,id3 title", |
1419 | NULL, 2, ID2P(LANG_DISPLAY_TRACK_NAME_ONLY), | 1419 | NULL, 3, ID2P(LANG_DISPLAY_TRACK_NAME_ONLY), |
1420 | ID2P(LANG_DISPLAY_FULL_PATH)), | 1420 | ID2P(LANG_DISPLAY_FULL_PATH), ID2P(LANG_ID3_TITLE)), |
1421 | CHOICE_SETTING(0, recursive_dir_insert, LANG_RECURSE_DIRECTORY , RECURSE_ON, | 1421 | CHOICE_SETTING(0, recursive_dir_insert, LANG_RECURSE_DIRECTORY , RECURSE_ON, |
1422 | "recursive directory insert", off_on_ask, NULL , 3 , | 1422 | "recursive directory insert", off_on_ask, NULL , 3 , |
1423 | ID2P(LANG_OFF), ID2P(LANG_ON), ID2P(LANG_ASK)), | 1423 | ID2P(LANG_OFF), ID2P(LANG_ON), ID2P(LANG_ASK)), |