diff options
author | William Wilgus <wilgus.william@gmail.com> | 2022-11-17 01:25:41 -0500 |
---|---|---|
committer | William Wilgus <wilgus.william@gmail.com> | 2022-11-17 01:43:16 -0500 |
commit | 0b7a387671a56a1b526b3672cd695b5764597f3e (patch) | |
tree | 07c9c337f002a647c5e6c7eaf0a6b3c5245097cb /apps/root_menu.c | |
parent | 4c3937591c510a22c724d18dae9367bb1b786698 (diff) | |
download | rockbox-0b7a387671a56a1b526b3672cd695b5764597f3e.tar.gz rockbox-0b7a387671a56a1b526b3672cd695b5764597f3e.zip |
open_plugins add name when plugin can't open & check LANG_LAST_INDEX_IN_ARRAY
can't open '' was confusing for users so pass the key to open plugin
in theory you could have a plugin that defaulted to these lang_ids
run but its good enough to tell the user what failed to open IMO
lang_id changes mess with open_plugin since it uses them as look-up keys
so add checks for LANG_LAST_INDEX_IN_ARRAY to the checksum
the plugin now removes entries with an invalid checksum
devices with harddrives only append their .dat file so have them skip entries
with invalid checksums and only notify user if a valid entry wasn't found
(these users can run the open_plugins plugin to remove invalid entries)
Change-Id: Icf157675beaccda785643d5a9ed032a7cde30f12
Diffstat (limited to 'apps/root_menu.c')
-rw-r--r-- | apps/root_menu.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/apps/root_menu.c b/apps/root_menu.c index ae3d1b39b0..c70237fdf7 100644 --- a/apps/root_menu.c +++ b/apps/root_menu.c | |||
@@ -730,6 +730,8 @@ static int load_plugin_screen(char *key) | |||
730 | char *param = open_plugin_entry.param; | 730 | char *param = open_plugin_entry.param; |
731 | if (param[0] == '\0') | 731 | if (param[0] == '\0') |
732 | param = NULL; | 732 | param = NULL; |
733 | if (path[0] == '\0' && key) | ||
734 | path = P2STR((unsigned char *)key); | ||
733 | 735 | ||
734 | int ret = plugin_load(path, param); | 736 | int ret = plugin_load(path, param); |
735 | 737 | ||