diff options
| author | Amaury Pouly <amaury.pouly@gmail.com> | 2017-01-16 00:10:38 +0100 |
|---|---|---|
| committer | Gerrit Rockbox <gerrit@rockbox.org> | 2017-02-04 17:24:47 +0100 |
| commit | d7871914acd2ed77f43344e36e08944524a67d9e (patch) | |
| tree | 7bcef243d9b53c3703c305b8a5f9f8a8488eabfb /apps/recorder | |
| parent | 1245c5fe61f6ca8e1980a33a8b8f7ea4322829fd (diff) | |
| download | rockbox-d7871914acd2ed77f43344e36e08944524a67d9e.tar.gz rockbox-d7871914acd2ed77f43344e36e08944524a67d9e.zip | |
Fix dangerous casts
On Windows 64-bit, the size of long is 32-bit, thus any pointer to long cast is
not valid. In any case, one should use intptr_t and ptrdiff_t when casting
to integers. This commit attempts to fix all instances reported by GCC.
When relevant, I replaced code by the macros PTR_ADD, ALIGN_UP from system.h
Change-Id: I2273b0e8465d3c4689824717ed5afa5ed238a2dc
Diffstat (limited to 'apps/recorder')
| -rw-r--r-- | apps/recorder/keyboard.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/recorder/keyboard.c b/apps/recorder/keyboard.c index fed8605714..ceb8de00fb 100644 --- a/apps/recorder/keyboard.c +++ b/apps/recorder/keyboard.c | |||
| @@ -255,7 +255,7 @@ static void kbd_inschar(struct edit_state *state, unsigned short ch) | |||
| 255 | 255 | ||
| 256 | len = strlen(state->text); | 256 | len = strlen(state->text); |
| 257 | utf8 = utf8encode(ch, tmp); | 257 | utf8 = utf8encode(ch, tmp); |
| 258 | j = (long)utf8 - (long)tmp; | 258 | j = (intptr_t)utf8 - (intptr_t)tmp; |
| 259 | 259 | ||
| 260 | if (len + j < state->buflen) | 260 | if (len + j < state->buflen) |
| 261 | { | 261 | { |