summaryrefslogtreecommitdiff
path: root/apps/recorder/pcm_record.c
diff options
context:
space:
mode:
authorThomas Martitz <kugel@rockbox.org>2011-08-14 15:13:00 +0000
committerThomas Martitz <kugel@rockbox.org>2011-08-14 15:13:00 +0000
commitd1322b71595336740eb5e18e5deed056ddb71c7a (patch)
tree812db6a9c2e9d78405ec0ed38465fd88dc5be748 /apps/recorder/pcm_record.c
parent9b9bd73dfb212d4192fccc5fc5e269fc6499139c (diff)
downloadrockbox-d1322b71595336740eb5e18e5deed056ddb71c7a.tar.gz
rockbox-d1322b71595336740eb5e18e5deed056ddb71c7a.zip
GSoC/Buflib: Replace all direct accesses to audiobuf with buffer API functions.
Namely, introduce buffer_get_buffer() and buffer_release_buffer(). buffer_get_buffer() aquires all available and grabs a lock, attempting to call buffer_alloc() or buffer_get_buffer() while this lock is locked will cause a panicf() (doesn't actually happen, but is for debugging purpose). buffer_release_buffer() unlocks that lock and can additionally increment the audiobuf buffer to make an allocation. Pass 0 to only unlock if buffer was used temporarily only. buffer_available() is a replacement function to query audiobuflen, i.e. what's left in the buffer. Buffer init is moved up in the init chain and handles ipodvideo64mb internally. Further changes happened to mp3data.c and talk.c as to not call the above API functions, but get the buffer from callers. The caller is the audio system which has the buffer lock while mp3data.c and talk mess with the buffer. mpeg.c now implements some buffer related functions of playback.h, especially audio_get_buffer(), allowing to reduce #ifdef hell a tiny bit. audiobuf and audiobufend are local to buffer.c now. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30308 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/recorder/pcm_record.c')
-rw-r--r--apps/recorder/pcm_record.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/apps/recorder/pcm_record.c b/apps/recorder/pcm_record.c
index 8a832e409c..407a7e5f49 100644
--- a/apps/recorder/pcm_record.c
+++ b/apps/recorder/pcm_record.c
@@ -1643,14 +1643,12 @@ void enc_set_parameters(struct enc_parameters *params)
1643 logf("fnq files:%ld", fnq_size / MAX_PATH); 1643 logf("fnq files:%ld", fnq_size / MAX_PATH);
1644 1644
1645#if defined(DEBUG) 1645#if defined(DEBUG)
1646 logf("ab :%08lX", (uintptr_t)audiobuf);
1647 logf("pcm:%08lX", (uintptr_t)pcm_buffer); 1646 logf("pcm:%08lX", (uintptr_t)pcm_buffer);
1648 logf("enc:%08lX", (uintptr_t)enc_buffer); 1647 logf("enc:%08lX", (uintptr_t)enc_buffer);
1649 logf("res:%08lX", (uintptr_t)params->reserve_buffer); 1648 logf("res:%08lX", (uintptr_t)params->reserve_buffer);
1650 logf("wip:%08lX", (uintptr_t)wrap_id_p); 1649 logf("wip:%08lX", (uintptr_t)wrap_id_p);
1651 logf("fnq:%08lX", (uintptr_t)fn_queue); 1650 logf("fnq:%08lX", (uintptr_t)fn_queue);
1652 logf("end:%08lX", (uintptr_t)fn_queue + fnq_size); 1651 logf("end:%08lX", (uintptr_t)fn_queue + fnq_size);
1653 logf("abe:%08lX", (uintptr_t)audiobufend);
1654#endif 1652#endif
1655 1653
1656 /* init all chunk headers and reset indexes */ 1654 /* init all chunk headers and reset indexes */