diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2022-04-01 11:26:22 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2022-04-09 15:20:57 +0100 |
commit | 5aa0fc3b008e976a0d61a55814666229f2da47c8 (patch) | |
tree | cb7702db27a216ddfd897af5d617edd56a97bce3 /apps/recorder/jpeg_load.c | |
parent | 7718b244011661a5273121d1b545a18f1a5cd497 (diff) | |
download | rockbox-5aa0fc3b008e976a0d61a55814666229f2da47c8.tar.gz rockbox-5aa0fc3b008e976a0d61a55814666229f2da47c8.zip |
jpeg: provide a rough estimate of decoder memory overhead
JPEG decoding requires additional space in the bitmap buffer beyond
what is needed for the decoded pixel data. Provide a way to estimate
how much overhead is needed.
The actual overhead is sizeof(struct jpeg) + decode_buf_size, where
the latter depends on the image size and JPEG encoding used. From my
testing decode_buf_size is normally pretty small (under 5 KiB) but
looking at the code it could be large in some cases, primarily with
large images, so 32 KiB seems to be a decent compromise. Someone who
knows better about JPEG should pick a better value if that's too big.
Using a constant is obviously not the most accurate but it seems to
be the simplest option for retrofitting to existing code.
Change-Id: I573b0abb8ca2d79e43f185010487f07226edb793
Diffstat (limited to 'apps/recorder/jpeg_load.c')
-rw-r--r-- | apps/recorder/jpeg_load.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/apps/recorder/jpeg_load.c b/apps/recorder/jpeg_load.c index 9ab42b7a9f..5b287aff75 100644 --- a/apps/recorder/jpeg_load.c +++ b/apps/recorder/jpeg_load.c | |||
@@ -2228,4 +2228,15 @@ int read_jpeg_fd(int fd, | |||
2228 | } | 2228 | } |
2229 | #endif | 2229 | #endif |
2230 | 2230 | ||
2231 | const size_t JPEG_DECODE_OVERHEAD = | ||
2232 | /* Reserve an arbitrary amount for the decode buffer | ||
2233 | * FIXME: Somebody who knows what they're doing should look at this */ | ||
2234 | (32 * 1024) | ||
2235 | #ifndef JPEG_FROM_MEM | ||
2236 | /* Unless the struct jpeg is defined statically, we need to allocate | ||
2237 | * it in the bitmap buffer as well */ | ||
2238 | + sizeof(struct jpeg) | ||
2239 | #endif | ||
2240 | ; | ||
2241 | |||
2231 | /**************** end JPEG code ********************/ | 2242 | /**************** end JPEG code ********************/ |