events: Rework event subsystem (add_event, send_event) to be more versatile.

add_event_ex is added that takes an extra user_data pointer. This pointer is
passed to the callback (add_event and add_event_ex have slightly different
callbacks types). All callbacks also get the event id passed. Events added
with add_event_ex must be removed with remove_event_ex because the user_data
pointer must match in addition to the callback pointer.

On the other add_event is simplified to omit the oneshort parameter which
was almost always false (still there with add_event_ex).

As a side effect the ata_idle_notify callbacks are changed as well, they
do not take a data parameter anymore which was always NULL anyway.

This commit also adds some documentation to events.h

Change-Id: I13e29a0f88ef908f175b376d83550f9e0231f772

1 files changed, 5 insertions, 3 deletions

diff --git a/apps/radio/radioart.c b/apps/radio/radioart.c
index 86a987c14f..283815167a 100644
--- a/apps/radio/radioart.c
+++ b/apps/radio/radioart.c
@@ -145,7 +145,7 @@ int radio_get_art_hid(struct dim *requested_dim)
     return -1;
 }
 
-static void buffer_reset_handler(void *data)
+static void buffer_reset_handler(unsigned short id, void *data, void *user_data)
 {
     buf = NULL;
     for(int i=0;i<MAX_RADIOART_IMAGES;i++)
@@ -156,7 +156,9 @@ static void buffer_reset_handler(void *data)
         radioart[i].name[0] = '\0';
     }
 
+    (void)id;
     (void)data;
+    (void)user_data;
 }
 
 static int shrink_callback(int handle, unsigned hints, void* start, size_t old_size)
@@ -183,7 +185,7 @@ static int shrink_callback(int handle, unsigned hints, void* start, size_t old_s
         buf = start;
 
         /* one-shot */
-        add_event(BUFFER_EVENT_BUFFER_RESET, true, buffer_reset_handler);
+        add_event_ex(BUFFER_EVENT_BUFFER_RESET, true, buffer_reset_handler, NULL);
     }
 
     return BUFLIB_CB_OK;
@@ -203,7 +205,7 @@ void radioart_init(bool entering_screen)
         buffering_reset(core_get_data(handle), bufsize);
         buf = core_get_data(handle);
         /* one-shot */
-        add_event(BUFFER_EVENT_BUFFER_RESET, true, buffer_reset_handler);
+        add_event_ex(BUFFER_EVENT_BUFFER_RESET, true, buffer_reset_handler, NULL);
     }
     else /* init at startup */
     {