summaryrefslogtreecommitdiff
path: root/apps/plugins
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2022-09-19 11:52:30 +0100
committerAidan MacDonald <amachronic@protonmail.com>2022-10-05 11:22:34 -0400
commitff378deb69951a53b866f3d3c6ee13022e520436 (patch)
tree4e608fc9004d225b1121e3545642ab56186d0c0a /apps/plugins
parentead172c05d57568d201709c5fac77cbb8982bbd0 (diff)
downloadrockbox-ff378deb69951a53b866f3d3c6ee13022e520436.tar.gz
rockbox-ff378deb69951a53b866f3d3c6ee13022e520436.zip
gui: Remove gui_synclist_limit_scroll()
Since gui_synclist_do_button() overrides the setting at runtime there is no reason to have a public API call to set it. Really it should be a local variable, but it will be simpler to do that after refactoring how list wraparound behavior is handled. Change-Id: Id09d42197814102693752a9f64db8325118ca796
Diffstat (limited to 'apps/plugins')
-rw-r--r--apps/plugins/chessbox/chessbox_pgn.c1
-rw-r--r--apps/plugins/keybox.c1
-rw-r--r--apps/plugins/keyremap.c1
-rw-r--r--apps/plugins/open_plugins.c1
-rw-r--r--apps/plugins/properties.c1
-rw-r--r--apps/plugins/puzzles/rockbox.c3
-rw-r--r--apps/plugins/random_folder_advance_config.c1
-rw-r--r--apps/plugins/rb_info.c1
-rw-r--r--apps/plugins/shopper.c1
-rw-r--r--apps/plugins/shortcuts/shortcuts_view.c1
-rw-r--r--apps/plugins/text_editor.c1
11 files changed, 0 insertions, 13 deletions
diff --git a/apps/plugins/chessbox/chessbox_pgn.c b/apps/plugins/chessbox/chessbox_pgn.c
index 0d9da441b1..ccbcc7e91d 100644
--- a/apps/plugins/chessbox/chessbox_pgn.c
+++ b/apps/plugins/chessbox/chessbox_pgn.c
@@ -678,7 +678,6 @@ struct pgn_game_node* pgn_show_game_list(struct pgn_game_node* first_game){
678 if (rb->global_settings->talk_menu) 678 if (rb->global_settings->talk_menu)
679 rb->gui_synclist_set_voice_callback(&games_list, speak_game_selection); 679 rb->gui_synclist_set_voice_callback(&games_list, speak_game_selection);
680 rb->gui_synclist_set_nb_items(&games_list, i); 680 rb->gui_synclist_set_nb_items(&games_list, i);
681 rb->gui_synclist_limit_scroll(&games_list, true);
682 rb->gui_synclist_select_item(&games_list, 0); 681 rb->gui_synclist_select_item(&games_list, 0);
683 682
684 rb->gui_synclist_draw(&games_list); 683 rb->gui_synclist_draw(&games_list);
diff --git a/apps/plugins/keybox.c b/apps/plugins/keybox.c
index f8c6800a4d..38783508e7 100644
--- a/apps/plugins/keybox.c
+++ b/apps/plugins/keybox.c
@@ -659,7 +659,6 @@ enum plugin_status plugin_start(const void *parameter)
659 rb->gui_synclist_set_title(&kb_list, "Keybox", NOICON); 659 rb->gui_synclist_set_title(&kb_list, "Keybox", NOICON);
660 rb->gui_synclist_set_icon_callback(&kb_list, NULL); 660 rb->gui_synclist_set_icon_callback(&kb_list, NULL);
661 rb->gui_synclist_set_nb_items(&kb_list, 0); 661 rb->gui_synclist_set_nb_items(&kb_list, 0);
662 rb->gui_synclist_limit_scroll(&kb_list, false);
663 rb->gui_synclist_select_item(&kb_list, 0); 662 rb->gui_synclist_select_item(&kb_list, 0);
664 663
665 init_ll(); 664 init_ll();
diff --git a/apps/plugins/keyremap.c b/apps/plugins/keyremap.c
index a4ce1c48e6..aaf530318a 100644
--- a/apps/plugins/keyremap.c
+++ b/apps/plugins/keyremap.c
@@ -1950,7 +1950,6 @@ static void synclist_set(int id, int selected_item, int items, int sel_size)
1950 rb->gui_synclist_set_icon_callback(&lists,NULL); 1950 rb->gui_synclist_set_icon_callback(&lists,NULL);
1951 rb->gui_synclist_set_voice_callback(&lists, list_voice_cb); 1951 rb->gui_synclist_set_voice_callback(&lists, list_voice_cb);
1952 rb->gui_synclist_set_nb_items(&lists,items); 1952 rb->gui_synclist_set_nb_items(&lists,items);
1953 rb->gui_synclist_limit_scroll(&lists,true);
1954 rb->gui_synclist_select_item(&lists, selected_item); 1953 rb->gui_synclist_select_item(&lists, selected_item);
1955 printcell_enable(&lists, false, false); 1954 printcell_enable(&lists, false, false);
1956 1955
diff --git a/apps/plugins/open_plugins.c b/apps/plugins/open_plugins.c
index 3a0c34d8d6..0bd9740fe7 100644
--- a/apps/plugins/open_plugins.c
+++ b/apps/plugins/open_plugins.c
@@ -623,7 +623,6 @@ static void synclist_set(char* menu_id, int selection, int items, int sel_size)
623 rb->gui_synclist_set_icon_callback(&lists,NULL); 623 rb->gui_synclist_set_icon_callback(&lists,NULL);
624 rb->gui_synclist_set_voice_callback(&lists, list_voice_cb); 624 rb->gui_synclist_set_voice_callback(&lists, list_voice_cb);
625 rb->gui_synclist_set_nb_items(&lists,items); 625 rb->gui_synclist_set_nb_items(&lists,items);
626 rb->gui_synclist_limit_scroll(&lists,true);
627 rb->gui_synclist_select_item(&lists, selection); 626 rb->gui_synclist_select_item(&lists, selection);
628 list_voice_cb(selection, menu_id); 627 list_voice_cb(selection, menu_id);
629} 628}
diff --git a/apps/plugins/properties.c b/apps/plugins/properties.c
index c4378a0356..89ea722e9e 100644
--- a/apps/plugins/properties.c
+++ b/apps/plugins/properties.c
@@ -389,7 +389,6 @@ enum plugin_status plugin_start(const void* parameter)
389 rb->gui_synclist_set_nb_items(&properties_lists, 389 rb->gui_synclist_set_nb_items(&properties_lists,
390 2 * (props_type == PROPS_FILE ? NUM_FILE_PROPERTIES : 390 2 * (props_type == PROPS_FILE ? NUM_FILE_PROPERTIES :
391 NUM_DIR_PROPERTIES)); 391 NUM_DIR_PROPERTIES));
392 rb->gui_synclist_limit_scroll(&properties_lists, true);
393 rb->gui_synclist_select_item(&properties_lists, 0); 392 rb->gui_synclist_select_item(&properties_lists, 0);
394 rb->gui_synclist_draw(&properties_lists); 393 rb->gui_synclist_draw(&properties_lists);
395 rb->gui_synclist_speak_item(&properties_lists); 394 rb->gui_synclist_speak_item(&properties_lists);
diff --git a/apps/plugins/puzzles/rockbox.c b/apps/plugins/puzzles/rockbox.c
index 9a82cdde10..09b247e184 100644
--- a/apps/plugins/puzzles/rockbox.c
+++ b/apps/plugins/puzzles/rockbox.c
@@ -2450,7 +2450,6 @@ static int list_choose(const char *list_str, const char *title, int sel)
2450 rb->gui_synclist_init(&list, &config_choices_formatter, (void*)list_str, false, 1, NULL); 2450 rb->gui_synclist_init(&list, &config_choices_formatter, (void*)list_str, false, 1, NULL);
2451 rb->gui_synclist_set_icon_callback(&list, NULL); 2451 rb->gui_synclist_set_icon_callback(&list, NULL);
2452 rb->gui_synclist_set_nb_items(&list, n); 2452 rb->gui_synclist_set_nb_items(&list, n);
2453 rb->gui_synclist_limit_scroll(&list, false);
2454 2453
2455 rb->gui_synclist_select_item(&list, sel); 2454 rb->gui_synclist_select_item(&list, sel);
2456 2455
@@ -2664,7 +2663,6 @@ static bool config_menu(void)
2664 rb->gui_synclist_init(&list, &config_formatter, config, false, 1, NULL); 2663 rb->gui_synclist_init(&list, &config_formatter, config, false, 1, NULL);
2665 rb->gui_synclist_set_icon_callback(&list, NULL); 2664 rb->gui_synclist_set_icon_callback(&list, NULL);
2666 rb->gui_synclist_set_nb_items(&list, n); 2665 rb->gui_synclist_set_nb_items(&list, n);
2667 rb->gui_synclist_limit_scroll(&list, false);
2668 2666
2669 rb->gui_synclist_select_item(&list, 0); 2667 rb->gui_synclist_select_item(&list, 0);
2670 2668
@@ -2750,7 +2748,6 @@ static int do_preset_menu(struct preset_menu *menu, char *title, int selected)
2750 rb->gui_synclist_init(&list, &preset_formatter, menu, false, 1, NULL); 2748 rb->gui_synclist_init(&list, &preset_formatter, menu, false, 1, NULL);
2751 rb->gui_synclist_set_icon_callback(&list, NULL); 2749 rb->gui_synclist_set_icon_callback(&list, NULL);
2752 rb->gui_synclist_set_nb_items(&list, menu->n_entries); 2750 rb->gui_synclist_set_nb_items(&list, menu->n_entries);
2753 rb->gui_synclist_limit_scroll(&list, false);
2754 2751
2755 rb->gui_synclist_select_item(&list, selected); 2752 rb->gui_synclist_select_item(&list, selected);
2756 2753
diff --git a/apps/plugins/random_folder_advance_config.c b/apps/plugins/random_folder_advance_config.c
index 2c9fb411ac..2c22298cd4 100644
--- a/apps/plugins/random_folder_advance_config.c
+++ b/apps/plugins/random_folder_advance_config.c
@@ -311,7 +311,6 @@ static int edit_list(void)
311 rb->gui_synclist_init(&lists,list_get_name_cb,0, false, 1, NULL); 311 rb->gui_synclist_init(&lists,list_get_name_cb,0, false, 1, NULL);
312 rb->gui_synclist_set_icon_callback(&lists,NULL); 312 rb->gui_synclist_set_icon_callback(&lists,NULL);
313 rb->gui_synclist_set_nb_items(&lists,list->count); 313 rb->gui_synclist_set_nb_items(&lists,list->count);
314 rb->gui_synclist_limit_scroll(&lists,true);
315 rb->gui_synclist_select_item(&lists, 0); 314 rb->gui_synclist_select_item(&lists, 0);
316 315
317 while (!exit) 316 while (!exit)
diff --git a/apps/plugins/rb_info.c b/apps/plugins/rb_info.c
index 03c6671843..1385a5a9fc 100644
--- a/apps/plugins/rb_info.c
+++ b/apps/plugins/rb_info.c
@@ -514,7 +514,6 @@ static void synclist_set(char* menu_id, int selected_item, int items, int sel_si
514 rb->gui_synclist_set_icon_callback(&lists,NULL); 514 rb->gui_synclist_set_icon_callback(&lists,NULL);
515 rb->gui_synclist_set_voice_callback(&lists, list_voice_cb); 515 rb->gui_synclist_set_voice_callback(&lists, list_voice_cb);
516 rb->gui_synclist_set_nb_items(&lists,items); 516 rb->gui_synclist_set_nb_items(&lists,items);
517 rb->gui_synclist_limit_scroll(&lists,true);
518 rb->gui_synclist_select_item(&lists, selected_item); 517 rb->gui_synclist_select_item(&lists, selected_item);
519 518
520} 519}
diff --git a/apps/plugins/shopper.c b/apps/plugins/shopper.c
index 7129291c10..31ef44b831 100644
--- a/apps/plugins/shopper.c
+++ b/apps/plugins/shopper.c
@@ -304,7 +304,6 @@ enum plugin_status plugin_start(const void* parameter)
304 /* now dump it in the list */ 304 /* now dump it in the list */
305 rb->gui_synclist_init(&lists,list_get_name_cb,0, false, 1, NULL); 305 rb->gui_synclist_init(&lists,list_get_name_cb,0, false, 1, NULL);
306 rb->gui_synclist_set_icon_callback(&lists, list_get_icon_cb); 306 rb->gui_synclist_set_icon_callback(&lists, list_get_icon_cb);
307 rb->gui_synclist_limit_scroll(&lists,true);
308 create_view(&lists); 307 create_view(&lists);
309 rb->gui_synclist_set_nb_items(&lists,view_item_count); 308 rb->gui_synclist_set_nb_items(&lists,view_item_count);
310 rb->gui_synclist_select_item(&lists, 0); 309 rb->gui_synclist_select_item(&lists, 0);
diff --git a/apps/plugins/shortcuts/shortcuts_view.c b/apps/plugins/shortcuts/shortcuts_view.c
index f4c4b58bc1..9584731989 100644
--- a/apps/plugins/shortcuts/shortcuts_view.c
+++ b/apps/plugins/shortcuts/shortcuts_view.c
@@ -115,7 +115,6 @@ int list_sc(void)
115 rb->gui_synclist_set_title(&gui_sc, 115 rb->gui_synclist_set_title(&gui_sc,
116 (user_file?"Shortcuts (sealed)":"Shortcuts (editable)"), NOICON); 116 (user_file?"Shortcuts (sealed)":"Shortcuts (editable)"), NOICON);
117 rb->gui_synclist_set_nb_items(&gui_sc, sc_file.entry_cnt); 117 rb->gui_synclist_set_nb_items(&gui_sc, sc_file.entry_cnt);
118 rb->gui_synclist_limit_scroll(&gui_sc, false);
119 rb->gui_synclist_select_item(&gui_sc, 0); 118 rb->gui_synclist_select_item(&gui_sc, 0);
120 119
121 /* Draw the prepared widget to the LCD now */ 120 /* Draw the prepared widget to the LCD now */
diff --git a/apps/plugins/text_editor.c b/apps/plugins/text_editor.c
index 0cbb61c774..748e872d0b 100644
--- a/apps/plugins/text_editor.c
+++ b/apps/plugins/text_editor.c
@@ -214,7 +214,6 @@ static void setup_lists(struct gui_synclist *lists, int sel)
214 rb->gui_synclist_init(lists,list_get_name_cb,0, false, 1, NULL); 214 rb->gui_synclist_init(lists,list_get_name_cb,0, false, 1, NULL);
215 rb->gui_synclist_set_icon_callback(lists,NULL); 215 rb->gui_synclist_set_icon_callback(lists,NULL);
216 rb->gui_synclist_set_nb_items(lists,line_count); 216 rb->gui_synclist_set_nb_items(lists,line_count);
217 rb->gui_synclist_limit_scroll(lists,true);
218 rb->gui_synclist_select_item(lists, sel); 217 rb->gui_synclist_select_item(lists, sel);
219 rb->gui_synclist_draw(lists); 218 rb->gui_synclist_draw(lists);
220} 219}