Decouple the statusbar drawing from the rest of the screen drawing. it is not drawn roughly 4x per second automatically.

viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.)
All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false).

This commit also includes some menu/list viewport cleanups from kugel in FS#9603


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657

7 files changed, 0 insertions, 18 deletions

diff --git a/apps/plugins/calendar.c b/apps/plugins/calendar.c
index 17b98c7f56..55771de919 100644
--- a/apps/plugins/calendar.c
+++ b/apps/plugins/calendar.c
@@ -674,7 +674,6 @@ static bool view_events(int selected, struct shown *shown)
      
     while (!exit)
     {
-        rb->gui_syncstatusbar_draw(rb->statusbars, true);
         button = rb->get_action(CONTEXT_LIST,TIMEOUT_BLOCK);
         rb->gui_synclist_do_button(&gui_memos,&button,LIST_WRAP_UNLESS_HELD);
 
diff --git a/apps/plugins/chessbox/chessbox_pgn.c b/apps/plugins/chessbox/chessbox_pgn.c
index 1aff214332..8c92573b75 100644
--- a/apps/plugins/chessbox/chessbox_pgn.c
+++ b/apps/plugins/chessbox/chessbox_pgn.c
@@ -640,7 +640,6 @@ struct pgn_game_node* pgn_show_game_list(const struct plugin_api* api,
     rb->gui_synclist_select_item(&games_list, 0);
 
     while (true) {
-        rb->gui_syncstatusbar_draw(rb->statusbars, true);
         rb->gui_synclist_draw(&games_list);
         curr_selection = rb->gui_synclist_get_sel_pos(&games_list);
         button = rb->get_action(CONTEXT_LIST,TIMEOUT_BLOCK);
diff --git a/apps/plugins/keybox.c b/apps/plugins/keybox.c
index dae413ccbc..6ec86f6950 100644
--- a/apps/plugins/keybox.c
+++ b/apps/plugins/keybox.c
@@ -556,7 +556,6 @@ static int keybox(void)
 
     while (!done)
     {
-        rb->gui_syncstatusbar_draw(rb->statusbars, true);
         rb->gui_synclist_draw(&kb_list);
         button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK);
         if (rb->gui_synclist_do_button(&kb_list, &button, LIST_WRAP_ON))
diff --git a/apps/plugins/lib/oldmenuapi.c b/apps/plugins/lib/oldmenuapi.c
index b83f926532..a48a61bca6 100644
--- a/apps/plugins/lib/oldmenuapi.c
+++ b/apps/plugins/lib/oldmenuapi.c
@@ -98,7 +98,6 @@ int menu_show(int m)
     int key;
 
     rb->gui_synclist_draw(&(menus[m].synclist));
-    rb->gui_syncstatusbar_draw(rb->statusbars, true);
     while (!exit) {
         key = rb->get_action(CONTEXT_MAINMENU,HZ/2);
         /*
@@ -126,7 +125,6 @@ int menu_show(int m)
                     return MENU_ATTACHED_USB;
                 break;
         }
-        rb->gui_syncstatusbar_draw(rb->statusbars, false);
     }
     return MENU_SELECTED_EXIT;
 }
@@ -149,7 +147,6 @@ bool menu_run(int m)
                 if (menus[m].items[selected].function &&
                     menus[m].items[selected].function())
                     return  true;
-                rb->gui_syncstatusbar_draw(rb->statusbars, true);
             }
         }
     }
diff --git a/apps/plugins/shortcuts/shortcuts_view.c b/apps/plugins/shortcuts/shortcuts_view.c
index 09b25480e8..eb3cb9506c 100644
--- a/apps/plugins/shortcuts/shortcuts_view.c
+++ b/apps/plugins/shortcuts/shortcuts_view.c
@@ -58,8 +58,6 @@ enum sc_list_action_type draw_sc_list(struct gui_synclist gui_sc)
     rb->gui_synclist_draw(&gui_sc);
 
     while (true) {
-        /* draw the statusbar, should be done often */
-        rb->gui_syncstatusbar_draw(rb->statusbars, true);
         /* user input */
         button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK);
         if (rb->gui_synclist_do_button(&gui_sc, &button,
diff --git a/apps/plugins/star.c b/apps/plugins/star.c
index f358755e2a..c217fb922f 100644
--- a/apps/plugins/star.c
+++ b/apps/plugins/star.c
@@ -1008,9 +1008,6 @@ static int star_menu(void)
     FOR_NB_SCREENS(selection)
     {
         rb->viewport_set_defaults(&vp[selection], selection);
-        /* we are hiding the statusbar so fix the height also */
-        vp[selection].y = 0; 
-        vp[selection].height = rb->screens[selection]->lcdheight;
 #if LCD_DEPTH > 1
         if (rb->screens[selection]->depth > 1)
         {
@@ -1112,7 +1109,6 @@ static int star_menu(void)
         level--;
         star_run_game(level);
     }
-
     return PLUGIN_OK;
 }
 
diff --git a/apps/plugins/zxbox/zxbox_keyb.c b/apps/plugins/zxbox/zxbox_keyb.c
index 7ae3862fc2..36f1d519d9 100644
--- a/apps/plugins/zxbox/zxbox_keyb.c
+++ b/apps/plugins/zxbox/zxbox_keyb.c
@@ -443,8 +443,6 @@ int zx_kbd_input(char* text/*, int buflen*/)
                 rb->screens[l]->set_drawmode(DRMODE_SOLID);
             }
         
-
-/*        gui_syncstatusbar_draw(&statusbars, true);*/
         FOR_NB_SCREENS(l)
         rb->screens[l]->update();
 
@@ -554,10 +552,6 @@ int zx_kbd_input(char* text/*, int buflen*/)
             }
                 break;
 
-            case BUTTON_NONE:
-                /*gui_syncstatusbar_draw(&statusbars, false);*/
-
-                break;
 
             default:
                 if(rb->default_event_handler(button) == SYS_USB_CONNECTED)