text_viewer: cleanup & bugfix

cleanup:
    - don't use enum in struct / return values
    - don't use a getter for preferences but a global pointer
    - explicitely make enums start at 0
    - use static tables for header/footer settings
    - remove unneeded memset before strlcpy
    - use static buffer allocation, not dynamic
    - check header/footer preferences before using the callbacks
    - don't include font filename in archos player preferences (break
      file format)

bugfix:
    - statically allocate old preferences in tv_set_preferences()

Sometimes I can read a file on Clipv2, but it still aborts quite often
refs: FS#11399

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26998 a1c6a512-1295-4272-9138-f99709370657

1 files changed, 1 insertions, 10 deletions

diff --git a/apps/plugins/text_viewer/tv_window.h b/apps/plugins/text_viewer/tv_window.h
index fe87ec6569..abf475ae2d 100644
--- a/apps/plugins/text_viewer/tv_window.h
+++ b/apps/plugins/text_viewer/tv_window.h
@@ -26,20 +26,11 @@
 /*
  * initialize the window module
  *
- * [In] buf
- *          the start pointer of the buffer
- *
- * [In] size
- *          enabled buffer size
- *
- * [Out] used_size
- *          the size of the buffer which the pager uses
- *
  * return
  *     true  initialize success
  *     false initialize failure
  */
-bool tv_init_window(unsigned char *buf, size_t bufsize, size_t *used_size);
+bool tv_init_window(void);
 
 /* finalize the window module */
 void tv_finalize_window(void);