diff options
author | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-20 21:53:47 +0000 |
---|---|---|
committer | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-20 21:53:47 +0000 |
commit | 298316d19297eea82869b63235b535e5904fc0dd (patch) | |
tree | 0426e9c8cecac7532a88888e78e5e54ea9bb6145 /apps/plugins/text_viewer/tv_reader.h | |
parent | 17a2f9d8d2dfddd8d2d81ff638e21302efef1c8e (diff) | |
download | rockbox-298316d19297eea82869b63235b535e5904fc0dd.tar.gz rockbox-298316d19297eea82869b63235b535e5904fc0dd.zip |
text_viewer: cleanup & bugfix
cleanup:
- don't use enum in struct / return values
- don't use a getter for preferences but a global pointer
- explicitely make enums start at 0
- use static tables for header/footer settings
- remove unneeded memset before strlcpy
- use static buffer allocation, not dynamic
- check header/footer preferences before using the callbacks
- don't include font filename in archos player preferences (break
file format)
bugfix:
- statically allocate old preferences in tv_set_preferences()
Sometimes I can read a file on Clipv2, but it still aborts quite often
refs: FS#11399
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26998 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/plugins/text_viewer/tv_reader.h')
-rw-r--r-- | apps/plugins/text_viewer/tv_reader.h | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/apps/plugins/text_viewer/tv_reader.h b/apps/plugins/text_viewer/tv_reader.h index 464af1027a..2ee0b828ab 100644 --- a/apps/plugins/text_viewer/tv_reader.h +++ b/apps/plugins/text_viewer/tv_reader.h | |||
@@ -28,20 +28,11 @@ | |||
28 | /* | 28 | /* |
29 | * initialize the reader module | 29 | * initialize the reader module |
30 | * | 30 | * |
31 | * [In] buf | ||
32 | * the start pointer of the buffer | ||
33 | * | ||
34 | * [In] size | ||
35 | * enabled buffer size | ||
36 | * | ||
37 | * [Out] used_size | ||
38 | * the size of the buffer which the pager uses | ||
39 | * | ||
40 | * return | 31 | * return |
41 | * true initialize success | 32 | * true initialize success |
42 | * false initialize failure | 33 | * false initialize failure |
43 | */ | 34 | */ |
44 | bool tv_init_reader(unsigned char *buf, size_t bufsize, size_t *used_size); | 35 | bool tv_init_reader(void); |
45 | 36 | ||
46 | /* finalize the reader module */ | 37 | /* finalize the reader module */ |
47 | void tv_finalize_reader(void); | 38 | void tv_finalize_reader(void); |