diff options
author | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-20 21:53:47 +0000 |
---|---|---|
committer | Rafaël Carré <rafael.carre@gmail.com> | 2010-06-20 21:53:47 +0000 |
commit | 298316d19297eea82869b63235b535e5904fc0dd (patch) | |
tree | 0426e9c8cecac7532a88888e78e5e54ea9bb6145 /apps/plugins/text_viewer/tv_bookmark.c | |
parent | 17a2f9d8d2dfddd8d2d81ff638e21302efef1c8e (diff) | |
download | rockbox-298316d19297eea82869b63235b535e5904fc0dd.tar.gz rockbox-298316d19297eea82869b63235b535e5904fc0dd.zip |
text_viewer: cleanup & bugfix
cleanup:
- don't use enum in struct / return values
- don't use a getter for preferences but a global pointer
- explicitely make enums start at 0
- use static tables for header/footer settings
- remove unneeded memset before strlcpy
- use static buffer allocation, not dynamic
- check header/footer preferences before using the callbacks
- don't include font filename in archos player preferences (break
file format)
bugfix:
- statically allocate old preferences in tv_set_preferences()
Sometimes I can read a file on Clipv2, but it still aborts quite often
refs: FS#11399
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26998 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/plugins/text_viewer/tv_bookmark.c')
-rw-r--r-- | apps/plugins/text_viewer/tv_bookmark.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/plugins/text_viewer/tv_bookmark.c b/apps/plugins/text_viewer/tv_bookmark.c index 78e4c60a83..d379c924c4 100644 --- a/apps/plugins/text_viewer/tv_bookmark.c +++ b/apps/plugins/text_viewer/tv_bookmark.c | |||
@@ -224,7 +224,7 @@ void tv_select_bookmark(void) | |||
224 | } | 224 | } |
225 | 225 | ||
226 | /* move to the select position */ | 226 | /* move to the select position */ |
227 | if (tv_get_preferences()->vertical_scroll_mode == PAGE) | 227 | if (preferences->vertical_scroll_mode == PAGE) |
228 | select_pos.line = 0; | 228 | select_pos.line = 0; |
229 | 229 | ||
230 | tv_move_screen(select_pos.page, select_pos.line, SEEK_SET); | 230 | tv_move_screen(select_pos.page, select_pos.line, SEEK_SET); |