diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2022-09-19 12:48:15 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2022-10-05 11:22:55 -0400 |
commit | d5a081cbd1b871baf4e5d2c276fbabbc30c7994b (patch) | |
tree | aac3c9377be8433ad15c4ca2a733d3a7c81aad97 /apps/plugins/shortcuts/shortcuts_view.c | |
parent | ff378deb69951a53b866f3d3c6ee13022e520436 (diff) | |
download | rockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.tar.gz rockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.zip |
gui: Remove "enum list_wrap" from list action functions
Removing the "list_wrap" argument is actually pretty easy.
In practice, almost all lists are using LIST_WRAP_UNLESS_HELD
behavior so we can make that the default. A couple of lists
disable wraparound with LIST_WRAP_OFF; this is now achieved
by setting the list "wraparound" flag to false when setting
up the list. LIST_WRAP_ON was unused and is of questionable
value, so it has been removed entirely.
This makes list wraparound behavior a property of the list,
controlled solely by the "wraparound" flag. The result is a
simpler list API and implementation, without changing the
behavior of any lists.
Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a
Diffstat (limited to 'apps/plugins/shortcuts/shortcuts_view.c')
-rw-r--r-- | apps/plugins/shortcuts/shortcuts_view.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/apps/plugins/shortcuts/shortcuts_view.c b/apps/plugins/shortcuts/shortcuts_view.c index 9584731989..2a7970bebe 100644 --- a/apps/plugins/shortcuts/shortcuts_view.c +++ b/apps/plugins/shortcuts/shortcuts_view.c | |||
@@ -59,13 +59,8 @@ enum sc_list_action_type draw_sc_list(struct gui_synclist *gui_sc) | |||
59 | /* user input */ | 59 | /* user input */ |
60 | button = rb->get_action(CONTEXT_LIST, HZ); | 60 | button = rb->get_action(CONTEXT_LIST, HZ); |
61 | /* HZ so the status bar redraws corectly */ | 61 | /* HZ so the status bar redraws corectly */ |
62 | if (rb->gui_synclist_do_button(gui_sc, &button, | 62 | if (rb->gui_synclist_do_button(gui_sc, &button)) |
63 | LIST_WRAP_UNLESS_HELD)) { | ||
64 | /* automatic handling of user input. | ||
65 | * _UNLESS_HELD can be _ON or _OFF also | ||
66 | * selection changed, so redraw */ | ||
67 | continue; | 63 | continue; |
68 | } | ||
69 | switch (button) { /* process the user input */ | 64 | switch (button) { /* process the user input */ |
70 | case ACTION_STD_OK: | 65 | case ACTION_STD_OK: |
71 | return SCLA_SELECT; | 66 | return SCLA_SELECT; |