gui: Remove "enum list_wrap" from list action functions

Removing the "list_wrap" argument is actually pretty easy.
In practice, almost all lists are using LIST_WRAP_UNLESS_HELD
behavior so we can make that the default. A couple of lists
disable wraparound with LIST_WRAP_OFF; this is now achieved
by setting the list "wraparound" flag to false when setting
up the list. LIST_WRAP_ON was unused and is of questionable
value, so it has been removed entirely.

This makes list wraparound behavior a property of the list,
controlled solely by the "wraparound" flag. The result is a
simpler list API and implementation, without changing the
behavior of any lists.

Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a

1 files changed, 3 insertions, 3 deletions

diff --git a/apps/plugins/puzzles/rockbox.c b/apps/plugins/puzzles/rockbox.c
index 09b247e184..563820ba23 100644
--- a/apps/plugins/puzzles/rockbox.c
+++ b/apps/plugins/puzzles/rockbox.c
@@ -2458,7 +2458,7 @@ static int list_choose(const char *list_str, const char *title, int sel)
     {
         rb->gui_synclist_draw(&list);
         int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK);
-        if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_UNLESS_HELD))
+        if(rb->gui_synclist_do_button(&list, &button))
             continue;
         switch(button)
         {
@@ -2672,7 +2672,7 @@ static bool config_menu(void)
     {
         rb->gui_synclist_draw(&list);
         int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK);
-        if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_UNLESS_HELD))
+        if(rb->gui_synclist_do_button(&list, &button))
             continue;
         switch(button)
         {
@@ -2757,7 +2757,7 @@ static int do_preset_menu(struct preset_menu *menu, char *title, int selected)
     {
         rb->gui_synclist_draw(&list);
         int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK);
-        if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_UNLESS_HELD))
+        if(rb->gui_synclist_do_button(&list, &button))
             continue;
         switch(button)
         {