diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2022-09-19 12:48:15 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2022-10-05 11:22:55 -0400 |
commit | d5a081cbd1b871baf4e5d2c276fbabbc30c7994b (patch) | |
tree | aac3c9377be8433ad15c4ca2a733d3a7c81aad97 /apps/plugins/puzzles/rockbox.c | |
parent | ff378deb69951a53b866f3d3c6ee13022e520436 (diff) | |
download | rockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.tar.gz rockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.zip |
gui: Remove "enum list_wrap" from list action functions
Removing the "list_wrap" argument is actually pretty easy.
In practice, almost all lists are using LIST_WRAP_UNLESS_HELD
behavior so we can make that the default. A couple of lists
disable wraparound with LIST_WRAP_OFF; this is now achieved
by setting the list "wraparound" flag to false when setting
up the list. LIST_WRAP_ON was unused and is of questionable
value, so it has been removed entirely.
This makes list wraparound behavior a property of the list,
controlled solely by the "wraparound" flag. The result is a
simpler list API and implementation, without changing the
behavior of any lists.
Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a
Diffstat (limited to 'apps/plugins/puzzles/rockbox.c')
-rw-r--r-- | apps/plugins/puzzles/rockbox.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/apps/plugins/puzzles/rockbox.c b/apps/plugins/puzzles/rockbox.c index 09b247e184..563820ba23 100644 --- a/apps/plugins/puzzles/rockbox.c +++ b/apps/plugins/puzzles/rockbox.c | |||
@@ -2458,7 +2458,7 @@ static int list_choose(const char *list_str, const char *title, int sel) | |||
2458 | { | 2458 | { |
2459 | rb->gui_synclist_draw(&list); | 2459 | rb->gui_synclist_draw(&list); |
2460 | int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK); | 2460 | int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK); |
2461 | if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_UNLESS_HELD)) | 2461 | if(rb->gui_synclist_do_button(&list, &button)) |
2462 | continue; | 2462 | continue; |
2463 | switch(button) | 2463 | switch(button) |
2464 | { | 2464 | { |
@@ -2672,7 +2672,7 @@ static bool config_menu(void) | |||
2672 | { | 2672 | { |
2673 | rb->gui_synclist_draw(&list); | 2673 | rb->gui_synclist_draw(&list); |
2674 | int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK); | 2674 | int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK); |
2675 | if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_UNLESS_HELD)) | 2675 | if(rb->gui_synclist_do_button(&list, &button)) |
2676 | continue; | 2676 | continue; |
2677 | switch(button) | 2677 | switch(button) |
2678 | { | 2678 | { |
@@ -2757,7 +2757,7 @@ static int do_preset_menu(struct preset_menu *menu, char *title, int selected) | |||
2757 | { | 2757 | { |
2758 | rb->gui_synclist_draw(&list); | 2758 | rb->gui_synclist_draw(&list); |
2759 | int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK); | 2759 | int button = rb->get_action(CONTEXT_LIST, TIMEOUT_BLOCK); |
2760 | if(rb->gui_synclist_do_button(&list, &button, LIST_WRAP_UNLESS_HELD)) | 2760 | if(rb->gui_synclist_do_button(&list, &button)) |
2761 | continue; | 2761 | continue; |
2762 | switch(button) | 2762 | switch(button) |
2763 | { | 2763 | { |