diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2021-11-12 19:51:29 +0000 |
---|---|---|
committer | Solomon Peachy <pizza@shaftnet.org> | 2021-11-20 22:07:29 -0500 |
commit | a14347a6b3970cb327f6c60f308d93c88b33130d (patch) | |
tree | 6f64134f2601b29a057f2eaf9a34dc9efeabe201 /apps/plugins/properties.c | |
parent | 16a71a19a80932702cc2c03425ee0f831613b1b7 (diff) | |
download | rockbox-a14347a6b3970cb327f6c60f308d93c88b33130d.tar.gz rockbox-a14347a6b3970cb327f6c60f308d93c88b33130d.zip |
quickscreen: fix non-intuitive behavior of top/bottom items
The behavior of the top/bottom items is not intuitive when used
with settings like volume or brightness -- pressing up will
actually *decrease* the setting, and down will increase it.
This patch inverts the direction, so the top item will increase
the setting.
The reason for this is that historically, the quickscreen seems
to have had only 3 directions -- left, right, and bottom. Bottom
therefore selected the next value, and when top was introduced
it selected the previous value.
The counter-intuitive nature of this was later reported as a bug
on the Fuze V2 and got an incorrect fix (commit 2271995517) under
the assumption that ASCENDING_INT_SETTINGS was the issue.
Change-Id: I3be92534469cea4f5efd81ab024288c052367411
Diffstat (limited to 'apps/plugins/properties.c')
0 files changed, 0 insertions, 0 deletions