diff options
author | Nils Wallménius <nils@rockbox.org> | 2009-08-20 16:47:44 +0000 |
---|---|---|
committer | Nils Wallménius <nils@rockbox.org> | 2009-08-20 16:47:44 +0000 |
commit | 3200d04d75c5e7556ed8880b155533e881a4d1e1 (patch) | |
tree | 188e2c9525b25cb8922a14766e51ab02bad3f831 /apps/plugins/properties.c | |
parent | 0a1728444882cdbc6a0c815bd88464de25ad94e9 (diff) | |
download | rockbox-3200d04d75c5e7556ed8880b155533e881a4d1e1.tar.gz rockbox-3200d04d75c5e7556ed8880b155533e881a4d1e1.zip |
Make the formatter functions used by the settings return a pointer to avoid usless copying of lang strings, this brought with it a long chain of const correctness and a few random cleanups
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22440 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/plugins/properties.c')
-rw-r--r-- | apps/plugins/properties.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/apps/plugins/properties.c b/apps/plugins/properties.c index c76a25b06a..7cd29c126f 100644 --- a/apps/plugins/properties.c +++ b/apps/plugins/properties.c | |||
@@ -228,7 +228,8 @@ static bool dir_properties(char* selected_file) | |||
228 | return true; | 228 | return true; |
229 | } | 229 | } |
230 | 230 | ||
231 | char * get_props(int selected_item, void* data, char *buffer, size_t buffer_len) | 231 | static const char * get_props(int selected_item, void* data, |
232 | char *buffer, size_t buffer_len) | ||
232 | { | 233 | { |
233 | (void)data; | 234 | (void)data; |
234 | 235 | ||
@@ -263,8 +264,7 @@ char * get_props(int selected_item, void* data, char *buffer, size_t buffer_len) | |||
263 | rb->strlcpy(buffer, its_a_dir ? "" : str_duration, buffer_len); | 264 | rb->strlcpy(buffer, its_a_dir ? "" : str_duration, buffer_len); |
264 | break; | 265 | break; |
265 | default: | 266 | default: |
266 | rb->strlcpy(buffer, "ERROR", buffer_len); | 267 | return "ERROR"; |
267 | break; | ||
268 | } | 268 | } |
269 | return buffer; | 269 | return buffer; |
270 | } | 270 | } |