diff options
author | William Wilgus <wilgus.william@gmail.com> | 2020-10-07 02:01:35 -0400 |
---|---|---|
committer | William Wilgus <wilgus.william@gmail.com> | 2020-10-26 12:28:48 -0400 |
commit | 3237ae4a4ff9296a377ff9194a11038da161208f (patch) | |
tree | af4338c78467b9b0845d76c39da1fbe10f25e23e /apps/plugins/pictureflow/pictureflow.c | |
parent | 12f3ed1699d6bef25bed90ba95cbcc1a6bb4934a (diff) | |
download | rockbox-3237ae4a4ff9296a377ff9194a11038da161208f.tar.gz rockbox-3237ae4a4ff9296a377ff9194a11038da161208f.zip |
LCD core move buf ptr and address look up function viewport struct
I'm currently running up against the limitations of the lcd_draw functions
I want these functions to be able to be used on any size buffer not
just buffers with a stride matching the underlying device
[DONE] allow the framebuffer to be decoupled from the device framebuffer
[DONE need examples] allow for some simple blit like transformations
[DONE] remove the device framebuffer from the plugin api
[DONE}ditto remote framebuffer
[DONE] remove _viewport_get_framebuffer you can call struct *vp = lcd_set_viewport(NULL) and vp->buffer->fb_ptr
while remote lcds may compile (and work in the sim) its not been tested on targets
[FIXED] backdrops need work to be screen agnostic
[FIXED] screen statusbar is not being combined into the main viewport correctly yet
[FIXED] screen elements are displayed incorrectly after switch to void*
[FIXED] core didn't restore proper viewport on splash etc.
[NEEDS TESTING] remote lcd garbled data
[FIXED] osd lib garbled screen on bmp_part
[FIXED] grey_set_vp needs to return old viewport like lcd_set_viewport
[FIXED] Viewport update now handles viewports with differing buffers/strides by copying to the main buffer
[FIXED] splash on top of WPS leaves old framebuffer data (doesn't redraw)
[UPDATE] refined this a bit more to have clear_viewport set the clean bit and have skin_render do its own screen clear
scrolling viewports no longer trigger wps refresh
also fixed a bug where guisyncyesno was displaying and then disappearing
[ADDED!] New LCD macros that allow you to create properly size frame buffers in you desired size without wasting bytes
(LCD_ and LCD_REMOTE_)
LCD_STRIDE(w, h) same as STRIDE_MAIN
LCD_FBSTRIDE(w, h) returns target specific stride for a buffer W x H
LCD_NBELEMS(w, h) returns the number of fb_data sized elemenst needed for a buffer W x H
LCD_NATIVE_STRIDE(s) conversion between rockbox native vertical and lcd native stride (2bitH)
test_viewports.c has an example of usage
[FIXED!!] 2bit targets don't respect non-native strides
[FIXED] Few define snags
Change-Id: I0d04c3834e464eca84a5a715743a297a0cefd0af
Diffstat (limited to 'apps/plugins/pictureflow/pictureflow.c')
-rw-r--r-- | apps/plugins/pictureflow/pictureflow.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/apps/plugins/pictureflow/pictureflow.c b/apps/plugins/pictureflow/pictureflow.c index eadf9c3d0a..5f700aac83 100644 --- a/apps/plugins/pictureflow/pictureflow.c +++ b/apps/plugins/pictureflow/pictureflow.c | |||
@@ -35,6 +35,7 @@ | |||
35 | #include "lib/feature_wrappers.h" | 35 | #include "lib/feature_wrappers.h" |
36 | 36 | ||
37 | /******************************* Globals ***********************************/ | 37 | /******************************* Globals ***********************************/ |
38 | static fb_data *lcd_fb; | ||
38 | 39 | ||
39 | /* | 40 | /* |
40 | * Targets which use plugin_get_audio_buffer() can't have playback from | 41 | * Targets which use plugin_get_audio_buffer() can't have playback from |
@@ -190,7 +191,7 @@ GREY_INFO_STRUCT | |||
190 | #define BUFFER_HEIGHT _grey_info.height | 191 | #define BUFFER_HEIGHT _grey_info.height |
191 | typedef unsigned char pix_t; | 192 | typedef unsigned char pix_t; |
192 | #else /* LCD_DEPTH >= 8 */ | 193 | #else /* LCD_DEPTH >= 8 */ |
193 | #define LCD_BUF *rb->lcd_framebuffer | 194 | #define LCD_BUF lcd_fb |
194 | #define G_PIX LCD_RGBPACK | 195 | #define G_PIX LCD_RGBPACK |
195 | #define N_PIX LCD_RGBPACK | 196 | #define N_PIX LCD_RGBPACK |
196 | #define G_BRIGHT(y) LCD_RGBPACK(y,y,y) | 197 | #define G_BRIGHT(y) LCD_RGBPACK(y,y,y) |
@@ -3847,6 +3848,9 @@ static int pictureflow_main(void) | |||
3847 | 3848 | ||
3848 | enum plugin_status plugin_start(const void *parameter) | 3849 | enum plugin_status plugin_start(const void *parameter) |
3849 | { | 3850 | { |
3851 | struct viewport *vp_main = rb->lcd_set_viewport(NULL); | ||
3852 | lcd_fb = vp_main->buffer->fb_ptr; | ||
3853 | |||
3850 | int ret; | 3854 | int ret; |
3851 | (void) parameter; | 3855 | (void) parameter; |
3852 | 3856 | ||