Make open() posix compliant api-wise. A few calls (those with O_CREAT) need the additional optional mode parameter so add it. Impact for the core is almost zero, as open() is a wrapper macro for the real open function which doesn't take the variable parameter.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25844 a1c6a512-1295-4272-9138-f99709370657

2 files changed, 2 insertions, 6 deletions

diff --git a/apps/plugins/pdbox/PDa/intern/sfwrite~.c b/apps/plugins/pdbox/PDa/intern/sfwrite~.c
index ba63322380..49df0b7eeb 100644
--- a/apps/plugins/pdbox/PDa/intern/sfwrite~.c
+++ b/apps/plugins/pdbox/PDa/intern/sfwrite~.c
@@ -91,11 +91,7 @@ static void sfwrite_open(t_sfwrite *x,t_symbol *filename)
 
      sfwrite_close(x);
 
-#ifdef ROCKBOX
-     if ((x->x_file = open(fname, O_RDWR | O_CREAT)) < 0)
-#else
      if ((x->x_file = open(fname,O_RDWR | O_CREAT,0664)) < 0)
-#endif
      {
           error("can't create %s",fname);
           return;
diff --git a/apps/plugins/pdbox/PDa/src/g_array.c b/apps/plugins/pdbox/PDa/src/g_array.c
index 431cfeb31d..f0359e465a 100644
--- a/apps/plugins/pdbox/PDa/src/g_array.c
+++ b/apps/plugins/pdbox/PDa/src/g_array.c
@@ -1306,7 +1306,7 @@ static void garray_write(t_garray *x, t_symbol *filename)
         buf, MAXPDSTRING);
     sys_bashfilename(buf, buf);
 #ifdef ROCKBOX
-    if(!(fd = open(buf, O_WRONLY|O_CREAT|O_TRUNC)))
+    if(!(fd = open(buf, O_WRONLY|O_CREAT|O_TRUNC, 0666)))
 #else
     if (!(fd = fopen(buf, "w")))
 #endif
@@ -1388,7 +1388,7 @@ static void garray_write16(t_garray *x, t_symbol *filename, t_symbol *format)
         buf2, MAXPDSTRING);
     sys_bashfilename(buf2, buf2);
 #ifdef ROCKBOX
-    if(!(fd = open(buf2, O_WRONLY|O_CREAT|O_TRUNC)))
+    if(!(fd = open(buf2, O_WRONLY|O_CREAT|O_TRUNC, 0666)))
 #else
     if (!(fd = fopen(buf2, BINWRITEMODE)))
 #endif