summaryrefslogtreecommitdiff
path: root/apps/plugins/open_plugins.c
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2022-09-19 12:48:15 +0100
committerAidan MacDonald <amachronic@protonmail.com>2022-10-05 11:22:55 -0400
commitd5a081cbd1b871baf4e5d2c276fbabbc30c7994b (patch)
treeaac3c9377be8433ad15c4ca2a733d3a7c81aad97 /apps/plugins/open_plugins.c
parentff378deb69951a53b866f3d3c6ee13022e520436 (diff)
downloadrockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.tar.gz
rockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.zip
gui: Remove "enum list_wrap" from list action functions
Removing the "list_wrap" argument is actually pretty easy. In practice, almost all lists are using LIST_WRAP_UNLESS_HELD behavior so we can make that the default. A couple of lists disable wraparound with LIST_WRAP_OFF; this is now achieved by setting the list "wraparound" flag to false when setting up the list. LIST_WRAP_ON was unused and is of questionable value, so it has been removed entirely. This makes list wraparound behavior a property of the list, controlled solely by the "wraparound" flag. The result is a simpler list API and implementation, without changing the behavior of any lists. Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a
Diffstat (limited to 'apps/plugins/open_plugins.c')
-rw-r--r--apps/plugins/open_plugins.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/apps/plugins/open_plugins.c b/apps/plugins/open_plugins.c
index 0bd9740fe7..7230387efb 100644
--- a/apps/plugins/open_plugins.c
+++ b/apps/plugins/open_plugins.c
@@ -681,7 +681,7 @@ static void edit_menu(int selection)
681 { 681 {
682 action = rb->get_action(CONTEXT_LIST,TIMEOUT_BLOCK); 682 action = rb->get_action(CONTEXT_LIST,TIMEOUT_BLOCK);
683 683
684 if (rb->gui_synclist_do_button(&lists,&action,LIST_WRAP_UNLESS_HELD)) 684 if (rb->gui_synclist_do_button(&lists, &action))
685 continue; 685 continue;
686 selected_item = rb->gui_synclist_get_sel_pos(&lists); 686 selected_item = rb->gui_synclist_get_sel_pos(&lists);
687 switch (action) 687 switch (action)
@@ -864,7 +864,7 @@ reopen_datfile:
864 { 864 {
865 action = rb->get_action(CONTEXT_LIST,TIMEOUT_BLOCK); 865 action = rb->get_action(CONTEXT_LIST,TIMEOUT_BLOCK);
866 866
867 if (rb->gui_synclist_do_button(&lists,&action,LIST_WRAP_UNLESS_HELD)) 867 if (rb->gui_synclist_do_button(&lists, &action))
868 continue; 868 continue;
869 selection = rb->gui_synclist_get_sel_pos(&lists); 869 selection = rb->gui_synclist_get_sel_pos(&lists);
870 switch (action) 870 switch (action)