diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2022-09-19 12:48:15 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2022-10-05 11:22:55 -0400 |
commit | d5a081cbd1b871baf4e5d2c276fbabbc30c7994b (patch) | |
tree | aac3c9377be8433ad15c4ca2a733d3a7c81aad97 /apps/plugins/main_menu_config.c | |
parent | ff378deb69951a53b866f3d3c6ee13022e520436 (diff) | |
download | rockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.tar.gz rockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.zip |
gui: Remove "enum list_wrap" from list action functions
Removing the "list_wrap" argument is actually pretty easy.
In practice, almost all lists are using LIST_WRAP_UNLESS_HELD
behavior so we can make that the default. A couple of lists
disable wraparound with LIST_WRAP_OFF; this is now achieved
by setting the list "wraparound" flag to false when setting
up the list. LIST_WRAP_ON was unused and is of questionable
value, so it has been removed entirely.
This makes list wraparound behavior a property of the list,
controlled solely by the "wraparound" flag. The result is a
simpler list API and implementation, without changing the
behavior of any lists.
Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a
Diffstat (limited to 'apps/plugins/main_menu_config.c')
-rw-r--r-- | apps/plugins/main_menu_config.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/plugins/main_menu_config.c b/apps/plugins/main_menu_config.c index 9f651094b1..a5488ed2c0 100644 --- a/apps/plugins/main_menu_config.c +++ b/apps/plugins/main_menu_config.c | |||
@@ -188,7 +188,7 @@ enum plugin_status plugin_start(const void* parameter) | |||
188 | { | 188 | { |
189 | cur_sel = rb->gui_synclist_get_sel_pos(&list); | 189 | cur_sel = rb->gui_synclist_get_sel_pos(&list); |
190 | action = rb->get_action(CONTEXT_LIST,TIMEOUT_BLOCK); | 190 | action = rb->get_action(CONTEXT_LIST,TIMEOUT_BLOCK); |
191 | if (rb->gui_synclist_do_button(&list,&action,LIST_WRAP_UNLESS_HELD)) | 191 | if (rb->gui_synclist_do_button(&list, &action)) |
192 | continue; | 192 | continue; |
193 | 193 | ||
194 | switch (action) | 194 | switch (action) |