diff options
author | Thomas Martitz <kugel@rockbox.org> | 2012-05-26 22:57:21 +0200 |
---|---|---|
committer | Thomas Martitz <kugel@rockbox.org> | 2012-05-26 22:57:21 +0200 |
commit | d523fd6e6407137ce12395a49223ba41009357ba (patch) | |
tree | 8b85d11db596dc10b53be946ad1828856fd43125 /apps/plugins/lib | |
parent | 3f365fc06b67f8842b2e155349110f7c5659768d (diff) | |
download | rockbox-d523fd6e6407137ce12395a49223ba41009357ba.tar.gz rockbox-d523fd6e6407137ce12395a49223ba41009357ba.zip |
load_code/overlay: Don't close plugin handle before calling the plugin.
Doesnt fix an actual bug because closing a handle is a no-op on all
native targets and others dont use overlay.
Change-Id: Ie55e3fd4abd08b174d86ca25aed54a970dddbebd
Diffstat (limited to 'apps/plugins/lib')
-rw-r--r-- | apps/plugins/lib/overlay.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/apps/plugins/lib/overlay.c b/apps/plugins/lib/overlay.c index 21002ad43f..0ecc1bf3e7 100644 --- a/apps/plugins/lib/overlay.c +++ b/apps/plugins/lib/overlay.c | |||
@@ -52,6 +52,7 @@ enum plugin_status run_overlay(const void* parameter, | |||
52 | void *handle; | 52 | void *handle; |
53 | struct plugin_header *p_hdr; | 53 | struct plugin_header *p_hdr; |
54 | struct lc_header *hdr; | 54 | struct lc_header *hdr; |
55 | enum plugin_status retval = PLUGIN_ERROR; | ||
55 | 56 | ||
56 | audiobuf = rb->plugin_get_audio_buffer(&audiobuf_size); | 57 | audiobuf = rb->plugin_get_audio_buffer(&audiobuf_size); |
57 | if (!audiobuf) | 58 | if (!audiobuf) |
@@ -90,13 +91,11 @@ enum plugin_status run_overlay(const void* parameter, | |||
90 | goto error_close; | 91 | goto error_close; |
91 | } | 92 | } |
92 | 93 | ||
93 | rb->lc_close(handle); | ||
94 | |||
95 | *(p_hdr->api) = rb; | 94 | *(p_hdr->api) = rb; |
96 | return p_hdr->entry_point(parameter); | 95 | retval = p_hdr->entry_point(parameter); |
97 | 96 | /* fall through */ | |
98 | error_close: | 97 | error_close: |
99 | rb->lc_close(handle); | 98 | rb->lc_close(handle); |
100 | error: | 99 | error: |
101 | return PLUGIN_ERROR; | 100 | return retval; |
102 | } | 101 | } |