diff options
author | William Wilgus <wilgus.william@gmail.com> | 2021-08-25 22:18:14 -0400 |
---|---|---|
committer | William Wilgus <me.theuser@yahoo.com> | 2021-08-26 20:19:26 +0000 |
commit | cab8cea0f0b241c9221e220bf53c30c8b212274a (patch) | |
tree | 321a82989061835f97c46e8404d1df3252b67074 /apps/plugins/lib/SOURCES | |
parent | 30e96a373210f47da7a25276d49d5f7672f893d5 (diff) | |
download | rockbox-cab8cea0f0b241c9221e220bf53c30c8b212274a.tar.gz rockbox-cab8cea0f0b241c9221e220bf53c30c8b212274a.zip |
lcd_putsxyofs 16 bit lcd_mono_bitmap_part [AS] part duex
'Bugfix' mono_bitmap_part reads ahead in the buffer,
if the height is <= char bit pixels other memory gets read
found with [Address Sanitizer]
also g#3332 since this is clearly a problem across the code
instead place the check for height < 8 in the lcd_mono_bitmap_part function
second try places the check above the negative y offset
this was causing glitches on the Q1 and likely other TS targets
since a negative y was added to height it made it < CHAR_BIT setting
stride = 0 even though the bitmap was >= CHAR_BIT high
Change-Id: I13bb8ab472c2ae61302a6de5d9e2c78243354460
Diffstat (limited to 'apps/plugins/lib/SOURCES')
0 files changed, 0 insertions, 0 deletions