diff options
author | Christian Soffke <christian.soffke@gmail.com> | 2022-12-18 21:13:15 +0100 |
---|---|---|
committer | Christian Soffke <christian.soffke@gmail.com> | 2022-12-29 04:39:22 +0100 |
commit | faa2cb99429214de745bbc3e64e48a7432db51ae (patch) | |
tree | de2967e0e8237cb86422cd82488e110b97ff831e /apps/plugins/clock | |
parent | 52f59f637dfcb24900b30ed52c1d7725eab93364 (diff) | |
download | rockbox-faa2cb99429214de745bbc3e64e48a7432db51ae.tar.gz rockbox-faa2cb99429214de745bbc3e64e48a7432db51ae.zip |
plugins: Improve usability of iPod keymaps
- Reduce need to press multiple buttons at
the same time to quit a plugin
- Have "Menu" be default way to quit plugins or
to access plugin menu
- Fall back to (Long) "Select" or Long "Menu"
in cases where Menu button isn't available
(e.g. in ImageViewer and many games)
out of scope:
boomshine, lua_scripts, Rockpaint,
Doom, Duke3D, Pacbox, Quake,
Sgt-Puzzles, Wolf3D, XWorld,
Minesweeper, Pixel Painter, Spacerocks
Change-Id: I6d4dc7174695fe4b8ee9cbaccb21bdbfe6af5c48
Diffstat (limited to 'apps/plugins/clock')
-rw-r--r-- | apps/plugins/clock/clock.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/apps/plugins/clock/clock.c b/apps/plugins/clock/clock.c index d287c75598..c61b466aba 100644 --- a/apps/plugins/clock/clock.c +++ b/apps/plugins/clock/clock.c | |||
@@ -44,13 +44,19 @@ const struct button_mapping* plugin_contexts[]={ | |||
44 | 44 | ||
45 | #define ACTION_COUNTER_TOGGLE PLA_SELECT | 45 | #define ACTION_COUNTER_TOGGLE PLA_SELECT |
46 | #define ACTION_COUNTER_RESET PLA_SELECT_REPEAT | 46 | #define ACTION_COUNTER_RESET PLA_SELECT_REPEAT |
47 | #define ACTION_MENU PLA_CANCEL | ||
48 | #define ACTION_MODE_NEXT PLA_RIGHT | 47 | #define ACTION_MODE_NEXT PLA_RIGHT |
49 | #define ACTION_MODE_NEXT_REPEAT PLA_RIGHT_REPEAT | 48 | #define ACTION_MODE_NEXT_REPEAT PLA_RIGHT_REPEAT |
50 | #define ACTION_MODE_PREV PLA_LEFT | 49 | #define ACTION_MODE_PREV PLA_LEFT |
51 | #define ACTION_MODE_PREV_REPEAT PLA_LEFT_REPEAT | 50 | #define ACTION_MODE_PREV_REPEAT PLA_LEFT_REPEAT |
51 | #if (CONFIG_KEYPAD == IPOD_1G2G_PAD) \ | ||
52 | || (CONFIG_KEYPAD == IPOD_3G_PAD) \ | ||
53 | || (CONFIG_KEYPAD == IPOD_4G_PAD) | ||
54 | #define ACTION_MENU PLA_UP | ||
55 | #else | ||
56 | #define ACTION_MENU PLA_CANCEL | ||
52 | #define ACTION_SKIN_NEXT PLA_UP | 57 | #define ACTION_SKIN_NEXT PLA_UP |
53 | #define ACTION_SKIN_NEXT_REPEAT PLA_UP_REPEAT | 58 | #define ACTION_SKIN_NEXT_REPEAT PLA_UP_REPEAT |
59 | #endif | ||
54 | #define ACTION_SKIN_PREV PLA_DOWN | 60 | #define ACTION_SKIN_PREV PLA_DOWN |
55 | #define ACTION_SKIN_PREV_REPEAT PLA_DOWN_REPEAT | 61 | #define ACTION_SKIN_PREV_REPEAT PLA_DOWN_REPEAT |
56 | 62 | ||
@@ -165,10 +171,12 @@ enum plugin_status plugin_start(const void* parameter){ | |||
165 | case ACTION_SKIN_PREV: | 171 | case ACTION_SKIN_PREV: |
166 | clock_settings_skin_next(&clock_settings); | 172 | clock_settings_skin_next(&clock_settings); |
167 | break; | 173 | break; |
174 | #if defined(ACTION_SKIN_NEXT) && defined(ACTION_SKIN_NEXT_REPEAT) | ||
168 | case ACTION_SKIN_NEXT_REPEAT: | 175 | case ACTION_SKIN_NEXT_REPEAT: |
169 | case ACTION_SKIN_NEXT: | 176 | case ACTION_SKIN_NEXT: |
170 | clock_settings_skin_previous(&clock_settings); | 177 | clock_settings_skin_previous(&clock_settings); |
171 | break; | 178 | break; |
179 | #endif | ||
172 | case ACTION_MENU: | 180 | case ACTION_MENU: |
173 | clock_draw_restore_colors(); | 181 | clock_draw_restore_colors(); |
174 | exit_clock=main_menu(); | 182 | exit_clock=main_menu(); |