diff options
author | Jonathan Gordon <rockbox@jdgordon.info> | 2009-12-09 07:25:46 +0000 |
---|---|---|
committer | Jonathan Gordon <rockbox@jdgordon.info> | 2009-12-09 07:25:46 +0000 |
commit | b2eb44ce0eb24632a46b0ea8c8c46a8f2ba35e24 (patch) | |
tree | ff3c0e14e9a53c08749ee1f233a5b1e887d3561a /apps/plugin.c | |
parent | 85aad9b3972208b0e34ba0241ebb5314118ae05e (diff) | |
download | rockbox-b2eb44ce0eb24632a46b0ea8c8c46a8f2ba35e24.tar.gz rockbox-b2eb44ce0eb24632a46b0ea8c8c46a8f2ba35e24.zip |
FS#10824 - viewport/statusbar API rework.
Hopefully the only user visible changes are:
- fm and recording screens go by the statusbar setting (sbs or inbuilt)
- plugins go back to using the theme as they should for menus and lists
- splash screens might get cut a bit... entirely theme and splash dependant.. if there is a problematic one we can look at it later.
- hopefully nothing more than very minor screen flickerings... let me know exactly where they are so they can be fixed
New GUI screen rules:
* Screens assume that the theme (sbs+ui viewport+ maybe background image) are always enabled. They may be disabled on a per display basis, but MUST be re-enabled on exit
* Screens must not be coded in a way that requires a statusbar of any type.. the inbuilt bar will be removed shortly.
ALWAYS RESPECT THE USERS SETTINGS unless the screen requires the full display to fit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23904 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/plugin.c')
-rw-r--r-- | apps/plugin.c | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/apps/plugin.c b/apps/plugin.c index cc208e7500..03497208b1 100644 --- a/apps/plugin.c +++ b/apps/plugin.c | |||
@@ -230,7 +230,6 @@ static const struct plugin_api rockbox_api = { | |||
230 | lcd_remote_bitmap, | 230 | lcd_remote_bitmap, |
231 | #endif | 231 | #endif |
232 | viewport_set_defaults, | 232 | viewport_set_defaults, |
233 | viewportmanager_set_statusbar, | ||
234 | 233 | ||
235 | /* list */ | 234 | /* list */ |
236 | gui_synclist_init, | 235 | gui_synclist_init, |
@@ -680,8 +679,7 @@ static const struct plugin_api rockbox_api = { | |||
680 | 679 | ||
681 | int plugin_load(const char* plugin, const void* parameter) | 680 | int plugin_load(const char* plugin, const void* parameter) |
682 | { | 681 | { |
683 | int rc; | 682 | int rc, i; |
684 | int oldbars; | ||
685 | struct plugin_header *hdr; | 683 | struct plugin_header *hdr; |
686 | #ifdef SIMULATOR | 684 | #ifdef SIMULATOR |
687 | void *pd; | 685 | void *pd; |
@@ -787,7 +785,8 @@ int plugin_load(const char* plugin, const void* parameter) | |||
787 | lcd_remote_update(); | 785 | lcd_remote_update(); |
788 | #endif | 786 | #endif |
789 | 787 | ||
790 | oldbars = viewportmanager_set_statusbar(VP_SB_HIDE_ALL); | 788 | FOR_NB_SCREENS(i) |
789 | viewportmanager_theme_enable(i, false, NULL); | ||
791 | 790 | ||
792 | cpucache_invalidate(); | 791 | cpucache_invalidate(); |
793 | 792 | ||
@@ -834,12 +833,8 @@ int plugin_load(const char* plugin, const void* parameter) | |||
834 | #endif | 833 | #endif |
835 | #endif | 834 | #endif |
836 | 835 | ||
837 | viewportmanager_set_statusbar(oldbars); | 836 | FOR_NB_SCREENS(i) |
838 | 837 | viewportmanager_theme_undo(i); | |
839 | if (rc != PLUGIN_GOTO_WPS) | ||
840 | { | ||
841 | send_event(GUI_EVENT_REFRESH, NULL); | ||
842 | } | ||
843 | 838 | ||
844 | if (pfn_tsr_exit == NULL) | 839 | if (pfn_tsr_exit == NULL) |
845 | plugin_loaded = false; | 840 | plugin_loaded = false; |