FS#10824 - viewport/statusbar API rework.

Hopefully the only user visible changes are:
- fm and recording screens go by the statusbar setting (sbs or inbuilt)
- plugins go back to using the theme as they should for menus and lists
- splash screens might get cut a bit... entirely theme and splash dependant.. if there is a problematic one we can look at it later.
- hopefully nothing more than very minor screen flickerings... let me know exactly where they are so they can be fixed

New GUI screen rules:
* Screens assume that the theme (sbs+ui viewport+ maybe background image) are always enabled. They may be disabled on a per display basis, but MUST be re-enabled on exit
* Screens must not be coded in a way that requires a statusbar of any type.. the inbuilt bar will be removed shortly.
ALWAYS RESPECT THE USERS SETTINGS unless the screen requires the full display to fit.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23904 a1c6a512-1295-4272-9138-f99709370657

1 files changed, 5 insertions, 10 deletions

diff --git a/apps/plugin.c b/apps/plugin.c
index cc208e7500..03497208b1 100644
--- a/apps/plugin.c
+++ b/apps/plugin.c
@@ -230,7 +230,6 @@ static const struct plugin_api rockbox_api = {
     lcd_remote_bitmap,
 #endif
     viewport_set_defaults,
-    viewportmanager_set_statusbar,
     
     /* list */
     gui_synclist_init,
@@ -680,8 +679,7 @@ static const struct plugin_api rockbox_api = {
 
 int plugin_load(const char* plugin, const void* parameter)
 {
-    int rc;
-    int oldbars;
+    int rc, i;
     struct plugin_header *hdr;
 #ifdef SIMULATOR
     void *pd;
@@ -787,7 +785,8 @@ int plugin_load(const char* plugin, const void* parameter)
     lcd_remote_update();
 #endif
 
-    oldbars = viewportmanager_set_statusbar(VP_SB_HIDE_ALL);
+    FOR_NB_SCREENS(i)
+       viewportmanager_theme_enable(i, false, NULL);
 
     cpucache_invalidate();
     
@@ -834,12 +833,8 @@ int plugin_load(const char* plugin, const void* parameter)
 #endif
 #endif
 
-    viewportmanager_set_statusbar(oldbars);
-
-    if (rc != PLUGIN_GOTO_WPS)
-    {
-        send_event(GUI_EVENT_REFRESH, NULL);
-    }
+    FOR_NB_SCREENS(i)
+        viewportmanager_theme_undo(i);
 
     if (pfn_tsr_exit == NULL)
         plugin_loaded = false;