summaryrefslogtreecommitdiff
path: root/apps/playlist_viewer.c
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2022-09-19 12:48:15 +0100
committerAidan MacDonald <amachronic@protonmail.com>2022-10-05 11:22:55 -0400
commitd5a081cbd1b871baf4e5d2c276fbabbc30c7994b (patch)
treeaac3c9377be8433ad15c4ca2a733d3a7c81aad97 /apps/playlist_viewer.c
parentff378deb69951a53b866f3d3c6ee13022e520436 (diff)
downloadrockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.tar.gz
rockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.zip
gui: Remove "enum list_wrap" from list action functions
Removing the "list_wrap" argument is actually pretty easy. In practice, almost all lists are using LIST_WRAP_UNLESS_HELD behavior so we can make that the default. A couple of lists disable wraparound with LIST_WRAP_OFF; this is now achieved by setting the list "wraparound" flag to false when setting up the list. LIST_WRAP_ON was unused and is of questionable value, so it has been removed entirely. This makes list wraparound behavior a property of the list, controlled solely by the "wraparound" flag. The result is a simpler list API and implementation, without changing the behavior of any lists. Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a
Diffstat (limited to 'apps/playlist_viewer.c')
-rw-r--r--apps/playlist_viewer.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/apps/playlist_viewer.c b/apps/playlist_viewer.c
index 2f23d87c2b..d2774e67b0 100644
--- a/apps/playlist_viewer.c
+++ b/apps/playlist_viewer.c
@@ -844,8 +844,7 @@ enum playlist_viewer_result playlist_viewer_ex(const char* filename)
844 } 844 }
845 845
846 /* Timeout so we can determine if play status has changed */ 846 /* Timeout so we can determine if play status has changed */
847 bool res = list_do_action(CONTEXT_TREE, HZ/2, 847 bool res = list_do_action(CONTEXT_TREE, HZ/2, &playlist_lists, &button);
848 &playlist_lists, &button, LIST_WRAP_UNLESS_HELD);
849 /* during moving, another redraw is going to be needed, 848 /* during moving, another redraw is going to be needed,
850 * since viewer.selected_track is updated too late (after the first draw) 849 * since viewer.selected_track is updated too late (after the first draw)
851 * drawing the moving item needs it */ 850 * drawing the moving item needs it */
@@ -1131,8 +1130,7 @@ bool search_playlist(void)
1131 gui_synclist_speak_item(&playlist_lists); 1130 gui_synclist_speak_item(&playlist_lists);
1132 while (!exit) 1131 while (!exit)
1133 { 1132 {
1134 if (list_do_action(CONTEXT_LIST, HZ/4, 1133 if (list_do_action(CONTEXT_LIST, HZ/4, &playlist_lists, &button))
1135 &playlist_lists, &button, LIST_WRAP_UNLESS_HELD))
1136 continue; 1134 continue;
1137 switch (button) 1135 switch (button)
1138 { 1136 {