diff options
author | Nils Wallménius <nils@rockbox.org> | 2009-08-20 16:47:44 +0000 |
---|---|---|
committer | Nils Wallménius <nils@rockbox.org> | 2009-08-20 16:47:44 +0000 |
commit | 3200d04d75c5e7556ed8880b155533e881a4d1e1 (patch) | |
tree | 188e2c9525b25cb8922a14766e51ab02bad3f831 /apps/playlist_viewer.c | |
parent | 0a1728444882cdbc6a0c815bd88464de25ad94e9 (diff) | |
download | rockbox-3200d04d75c5e7556ed8880b155533e881a4d1e1.tar.gz rockbox-3200d04d75c5e7556ed8880b155533e881a4d1e1.zip |
Make the formatter functions used by the settings return a pointer to avoid usless copying of lang strings, this brought with it a long chain of const correctness and a few random cleanups
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22440 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/playlist_viewer.c')
-rw-r--r-- | apps/playlist_viewer.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/apps/playlist_viewer.c b/apps/playlist_viewer.c index 7d3ff4ef9e..a829fc96f6 100644 --- a/apps/playlist_viewer.c +++ b/apps/playlist_viewer.c | |||
@@ -559,10 +559,10 @@ static int get_track_num( struct playlist_viewer * local_viewer, | |||
559 | return selected_item; | 559 | return selected_item; |
560 | } | 560 | } |
561 | 561 | ||
562 | static char *playlist_callback_name(int selected_item, | 562 | static const char* playlist_callback_name(int selected_item, |
563 | void *data, | 563 | void *data, |
564 | char *buffer, | 564 | char *buffer, |
565 | size_t buffer_len) | 565 | size_t buffer_len) |
566 | { | 566 | { |
567 | struct playlist_viewer * local_viewer = (struct playlist_viewer *)data; | 567 | struct playlist_viewer * local_viewer = (struct playlist_viewer *)data; |
568 | 568 | ||
@@ -778,15 +778,15 @@ exit: | |||
778 | return ret; | 778 | return ret; |
779 | } | 779 | } |
780 | 780 | ||
781 | static char *playlist_search_callback_name(int selected_item, void * data, | 781 | static const char* playlist_search_callback_name(int selected_item, void * data, |
782 | char *buffer, size_t buffer_len) | 782 | char *buffer, size_t buffer_len) |
783 | { | 783 | { |
784 | (void)buffer_len; /* this should probably be used */ | 784 | (void)buffer_len; /* this should probably be used */ |
785 | int *found_indicies = (int*)data; | 785 | int *found_indicies = (int*)data; |
786 | static struct playlist_track_info track; | 786 | static struct playlist_track_info track; |
787 | playlist_get_track_info(viewer.playlist, found_indicies[selected_item], &track); | 787 | playlist_get_track_info(viewer.playlist, found_indicies[selected_item], &track); |
788 | format_name(buffer, track.filename); | 788 | format_name(buffer, track.filename); |
789 | return(buffer); | 789 | return buffer; |
790 | } | 790 | } |
791 | 791 | ||
792 | bool search_playlist(void) | 792 | bool search_playlist(void) |