summaryrefslogtreecommitdiff
path: root/apps/playback.c
diff options
context:
space:
mode:
authorBrandon Low <lostlogic@rockbox.org>2007-11-05 16:02:12 +0000
committerBrandon Low <lostlogic@rockbox.org>2007-11-05 16:02:12 +0000
commit1df1e7b0c7f1932f45cfb189b43e873db1a85410 (patch)
treeedf57cc1bd9f3f7ba68b48c703f832798f16f122 /apps/playback.c
parent2d95fd524db6de67e91024ee4d947a4ee25c43b6 (diff)
downloadrockbox-1df1e7b0c7f1932f45cfb189b43e873db1a85410.tar.gz
rockbox-1df1e7b0c7f1932f45cfb189b43e873db1a85410.zip
Remove unused conf_preseek from buffering.c and all of its accountraments. This is _not_ a setting. This is a guessing tool used by either playback or buffering to serve its clients better. Use the REBUFFER_GUESS size in resume to help obviate pondlife's bug. This will also need to be used when FS8092 gets fixed correctly with a complete rebuffer for backward movements. It may also belong in buffering not playback, haven't decided for sure
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15475 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/playback.c')
-rw-r--r--apps/playback.c11
1 files changed, 5 insertions, 6 deletions
diff --git a/apps/playback.c b/apps/playback.c
index 650a69bbed..b31db800ad 100644
--- a/apps/playback.c
+++ b/apps/playback.c
@@ -1663,10 +1663,6 @@ static void codec_configure_callback(int setting, intptr_t value)
1663 buf_set_conf(BUFFERING_SET_CHUNKSIZE, value); 1663 buf_set_conf(BUFFERING_SET_CHUNKSIZE, value);
1664 break; 1664 break;
1665 1665
1666 case CODEC_SET_FILEBUF_PRESEEK:
1667 buf_set_conf(BUFFERING_SET_PRESEEK, value);
1668 break;
1669
1670 default: 1666 default:
1671 if (!dsp_configure(setting, value)) { logf("Illegal key:%d", setting); } 1667 if (!dsp_configure(setting, value)) { logf("Illegal key:%d", setting); }
1672 } 1668 }
@@ -2295,7 +2291,6 @@ static bool audio_load_track(int offset, bool start_play)
2295 set_current_codec(CODEC_IDX_AUDIO); 2291 set_current_codec(CODEC_IDX_AUDIO);
2296 buf_set_conf(BUFFERING_SET_WATERMARK, AUDIO_DEFAULT_WATERMARK); 2292 buf_set_conf(BUFFERING_SET_WATERMARK, AUDIO_DEFAULT_WATERMARK);
2297 buf_set_conf(BUFFERING_SET_CHUNKSIZE, AUDIO_DEFAULT_FILECHUNK); 2293 buf_set_conf(BUFFERING_SET_CHUNKSIZE, AUDIO_DEFAULT_FILECHUNK);
2298 buf_set_conf(BUFFERING_SET_PRESEEK, AUDIO_REBUFFER_GUESS_SIZE);
2299 dsp_configure(DSP_RESET, 0); 2294 dsp_configure(DSP_RESET, 0);
2300 set_current_codec(last_codec); 2295 set_current_codec(last_codec);
2301 2296
@@ -2441,8 +2436,12 @@ static bool audio_load_track(int offset, bool start_play)
2441 2436
2442 logf("alt:%s", trackname); 2437 logf("alt:%s", trackname);
2443 2438
2444 if (!file_offset && track_id3->first_frame_offset) 2439 if (file_offset > AUDIO_REBUFFER_GUESS_SIZE)
2440 file_offset -= AUDIO_REBUFFER_GUESS_SIZE;
2441 else if (track_id3->first_frame_offset)
2445 file_offset = track_id3->first_frame_offset; 2442 file_offset = track_id3->first_frame_offset;
2443 else
2444 file_offset = 0;
2446 2445
2447 tracks[track_widx].audio_hid = bufopen(trackname, file_offset, type); 2446 tracks[track_widx].audio_hid = bufopen(trackname, file_offset, type);
2448 2447