Just take out some out-of-date TODOs from playback.c and put a big FIXME in pcmbuf.c

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11217 a1c6a512-1295-4272-9138-f99709370657

1 files changed, 8 insertions, 1 deletions

diff --git a/apps/pcmbuf.c b/apps/pcmbuf.c
index 6d2f68a238..964ebbc901 100644
--- a/apps/pcmbuf.c
+++ b/apps/pcmbuf.c
@@ -38,7 +38,7 @@
 #include "thread.h"
 
 /* Keep watermark high for iPods at least (2s) */
-#define PCMBUF_WATERMARK     (NATIVE_FREQUENCY * 8)
+#define PCMBUF_WATERMARK     (NATIVE_FREQUENCY * 4 * 2)
 
 /* Structure we can use to queue pcm chunks in memory to be played
  * by the driver code. */
@@ -203,6 +203,13 @@ process_new_buffer:
             *realsize = 0;
             *realstart = NULL;
             CALL_IF_EXISTS(pcmbuf_event_handler);
+            /* FIXME: We need to find another way to keep the CPU from
+             * being left boosted, because this is boosting in interrupt
+             * context.  This is also not a good thing, because it will
+             * result in the CPU being deboosted if there is a legitimate
+             * buffer underrun (albeit only temporarily, because someone
+             * will reboost it soon, but it will make the skip longer
+             * than necessary. */
             pcmbuf_boost(false);
         }
     }