gui: Remove "enum list_wrap" from list action functions

Removing the "list_wrap" argument is actually pretty easy.
In practice, almost all lists are using LIST_WRAP_UNLESS_HELD
behavior so we can make that the default. A couple of lists
disable wraparound with LIST_WRAP_OFF; this is now achieved
by setting the list "wraparound" flag to false when setting
up the list. LIST_WRAP_ON was unused and is of questionable
value, so it has been removed entirely.

This makes list wraparound behavior a property of the list,
controlled solely by the "wraparound" flag. The result is a
simpler list API and implementation, without changing the
behavior of any lists.

Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a

1 files changed, 1 insertions, 2 deletions

diff --git a/apps/onplay.c b/apps/onplay.c
index e44e81ee5d..e4e2a7b3b8 100644
--- a/apps/onplay.c
+++ b/apps/onplay.c
@@ -429,8 +429,7 @@ static bool playing_time(void)
     gui_synclist_draw(&pt_lists);
     gui_synclist_speak_item(&pt_lists);
     while (true) {
-        if (list_do_action(CONTEXT_LIST, HZ/2,
-                          &pt_lists, &key, LIST_WRAP_UNLESS_HELD) == 0
+        if (list_do_action(CONTEXT_LIST, HZ/2, &pt_lists, &key) == 0
            && key!=ACTION_NONE && key!=ACTION_UNKNOWN)
         {
             talk_force_shutup();