diff options
author | Andree Buschmann <AndreeBuschmann@t-online.de> | 2011-03-16 22:05:46 +0000 |
---|---|---|
committer | Andree Buschmann <AndreeBuschmann@t-online.de> | 2011-03-16 22:05:46 +0000 |
commit | 742980f94c4018bb38e09f2437dd708d4ecda2b3 (patch) | |
tree | fe56b0463632e9d620565055c19350bc584818d5 /apps/mp3data.c | |
parent | 3706d6d0b5e672637dcc831aeb844dce4667ea65 (diff) | |
download | rockbox-742980f94c4018bb38e09f2437dd708d4ecda2b3.tar.gz rockbox-742980f94c4018bb38e09f2437dd708d4ecda2b3.zip |
Avoid magic numbers. Use the available defines to set up the bit mask to compare MPEG frame headers.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29607 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/mp3data.c')
-rw-r--r-- | apps/mp3data.c | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/apps/mp3data.c b/apps/mp3data.c index 31ed492679..90362e33ec 100644 --- a/apps/mp3data.c +++ b/apps/mp3data.c | |||
@@ -49,19 +49,19 @@ | |||
49 | #define VDEBUGF(...) do { } while(0) | 49 | #define VDEBUGF(...) do { } while(0) |
50 | #endif | 50 | #endif |
51 | 51 | ||
52 | #define SYNC_MASK (0x7ffL << 21) | 52 | #define SYNC_MASK (0x7ffL << 21) |
53 | #define VERSION_MASK (3L << 19) | 53 | #define VERSION_MASK (3L << 19) |
54 | #define LAYER_MASK (3L << 17) | 54 | #define LAYER_MASK (3L << 17) |
55 | #define PROTECTION_MASK (1L << 16) | 55 | #define PROTECTION_MASK (1L << 16) |
56 | #define BITRATE_MASK (0xfL << 12) | 56 | #define BITRATE_MASK (0xfL << 12) |
57 | #define SAMPLERATE_MASK (3L << 10) | 57 | #define SAMPLERATE_MASK (3L << 10) |
58 | #define PADDING_MASK (1L << 9) | 58 | #define PADDING_MASK (1L << 9) |
59 | #define PRIVATE_MASK (1L << 8) | 59 | #define PRIVATE_MASK (1L << 8) |
60 | #define CHANNELMODE_MASK (3L << 6) | 60 | #define CHANNELMODE_MASK (3L << 6) |
61 | #define MODE_EXT_MASK (3L << 4) | 61 | #define MODE_EXT_MASK (3L << 4) |
62 | #define COPYRIGHT_MASK (1L << 3) | 62 | #define COPYRIGHT_MASK (1L << 3) |
63 | #define ORIGINAL_MASK (1L << 2) | 63 | #define ORIGINAL_MASK (1L << 2) |
64 | #define EMPHASIS_MASK 3L | 64 | #define EMPHASIS_MASK (3L) |
65 | 65 | ||
66 | /* MPEG Version table, sorted by version index */ | 66 | /* MPEG Version table, sorted by version index */ |
67 | static const signed char version_table[4] = { | 67 | static const signed char version_table[4] = { |
@@ -206,8 +206,8 @@ static bool headers_have_same_type(unsigned long header1, | |||
206 | unsigned long header2) | 206 | unsigned long header2) |
207 | { | 207 | { |
208 | /* Compare MPEG version, layer and sampling frequency. If header1 is zero | 208 | /* Compare MPEG version, layer and sampling frequency. If header1 is zero |
209 | * it is assumed the headers are of same type. */ | 209 | * it is assumed both frame headers are of same type. */ |
210 | unsigned int mask = 0xfffe0c00; | 210 | unsigned int mask = SYNC_MASK | VERSION_MASK | LAYER_MASK | SAMPLERATE_MASK; |
211 | header1 &= mask; | 211 | header1 &= mask; |
212 | header2 &= mask; | 212 | header2 &= mask; |
213 | return header1 ? (header1 == header2) : true; | 213 | return header1 ? (header1 == header2) : true; |