summaryrefslogtreecommitdiff
path: root/apps/misc.h
diff options
context:
space:
mode:
authorChristian Soffke <christian.soffke@gmail.com>2022-11-27 01:15:14 +0100
committerChristian Soffke <christian.soffke@gmail.com>2022-12-11 11:50:33 +0100
commitdfd9c10589d25a966c7e2e4dedab57c59a1987fd (patch)
treef65fcbefd97eff19ec3605aa1dfc161ad4221da6 /apps/misc.h
parent90d1ac044857781c4885da8cbfde62ece344fce3 (diff)
downloadrockbox-dfd9c10589d25a966c7e2e4dedab57c59a1987fd.tar.gz
rockbox-dfd9c10589d25a966c7e2e4dedab57c59a1987fd.zip
Eliminate skin updates in between activities
1) Adds way to pop activity without refreshing the skin at the same time. Activities are sometimes popped in immediate succession, or one activity is popped before another one is pushed right away. This can lead to the UI appearing glitchy, due to an activity only appearing for a split-second, which is especially noticeable with complex skins that change the dimensions of the UI viewport depending on the current activity To fix this, prevent superfluous skin updates * when switching between: - WPS and browser - WPS and Playlist Catalogue - WPS and playlist - WPS and Settings/System/Plugins * when accessing Track Info or when displaying bookmarks using the context menu on the WPS * when switching from QuickScreen to Shortcuts Menu 2) The playlist viewer activity was pushed & popped redundantly by playlist_view. ---- NB: Behavior has remained unchanged in all instances of the code where pop_current_activity() has been replaced by pop_current_activity(ACTIVITY_REFRESH_NOW). Change-Id: I56b517b8c9dba823a9fed3a3f558d7469dcea9fd
Diffstat (limited to 'apps/misc.h')
-rw-r--r--apps/misc.h8
1 files changed, 7 insertions, 1 deletions
diff --git a/apps/misc.h b/apps/misc.h
index af520a7fd1..4f4527f686 100644
--- a/apps/misc.h
+++ b/apps/misc.h
@@ -214,8 +214,14 @@ struct mp3entry;
214int id3_get_replaygain_mode(const struct mp3entry *id3); 214int id3_get_replaygain_mode(const struct mp3entry *id3);
215void replaygain_update(void); 215void replaygain_update(void);
216 216
217enum activity_refresh
218{
219 ACTIVITY_REFRESH_DEFERRED = 0,
220 ACTIVITY_REFRESH_NOW,
221};
222
217void push_current_activity(enum current_activity screen); 223void push_current_activity(enum current_activity screen);
218void pop_current_activity(void); 224void pop_current_activity(enum activity_refresh refresh);
219enum current_activity get_current_activity(void); 225enum current_activity get_current_activity(void);
220 226
221/* format a sound value like: -1.05 dB */ 227/* format a sound value like: -1.05 dB */