summaryrefslogtreecommitdiff
path: root/apps/misc.c
diff options
context:
space:
mode:
authorAmaury Pouly <amaury.pouly@gmail.com>2017-01-16 00:10:38 +0100
committerGerrit Rockbox <gerrit@rockbox.org>2017-02-04 17:24:47 +0100
commitd7871914acd2ed77f43344e36e08944524a67d9e (patch)
tree7bcef243d9b53c3703c305b8a5f9f8a8488eabfb /apps/misc.c
parent1245c5fe61f6ca8e1980a33a8b8f7ea4322829fd (diff)
downloadrockbox-d7871914acd2ed77f43344e36e08944524a67d9e.tar.gz
rockbox-d7871914acd2ed77f43344e36e08944524a67d9e.zip
Fix dangerous casts
On Windows 64-bit, the size of long is 32-bit, thus any pointer to long cast is not valid. In any case, one should use intptr_t and ptrdiff_t when casting to integers. This commit attempts to fix all instances reported by GCC. When relevant, I replaced code by the macros PTR_ADD, ALIGN_UP from system.h Change-Id: I2273b0e8465d3c4689824717ed5afa5ed238a2dc
Diffstat (limited to 'apps/misc.c')
-rw-r--r--apps/misc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/misc.c b/apps/misc.c
index e460eb542c..3fdcab85e6 100644
--- a/apps/misc.c
+++ b/apps/misc.c
@@ -215,7 +215,7 @@ int fast_readline(int fd, char *buf, int buf_size, void *parameters,
215 count++; 215 count++;
216 if (next) 216 if (next)
217 { 217 {
218 pos = buf_size - ((long)next - (long)buf) - 1; 218 pos = buf_size - ((intptr_t)next - (intptr_t)buf) - 1;
219 memmove(buf, next, pos); 219 memmove(buf, next, pos);
220 } 220 }
221 else 221 else