summaryrefslogtreecommitdiff
path: root/apps/menus
diff options
context:
space:
mode:
authorChristian Soffke <christian.soffke@gmail.com>2022-11-27 01:15:14 +0100
committerChristian Soffke <christian.soffke@gmail.com>2022-12-11 11:50:33 +0100
commitdfd9c10589d25a966c7e2e4dedab57c59a1987fd (patch)
treef65fcbefd97eff19ec3605aa1dfc161ad4221da6 /apps/menus
parent90d1ac044857781c4885da8cbfde62ece344fce3 (diff)
downloadrockbox-dfd9c10589d25a966c7e2e4dedab57c59a1987fd.tar.gz
rockbox-dfd9c10589d25a966c7e2e4dedab57c59a1987fd.zip
Eliminate skin updates in between activities
1) Adds way to pop activity without refreshing the skin at the same time. Activities are sometimes popped in immediate succession, or one activity is popped before another one is pushed right away. This can lead to the UI appearing glitchy, due to an activity only appearing for a split-second, which is especially noticeable with complex skins that change the dimensions of the UI viewport depending on the current activity To fix this, prevent superfluous skin updates * when switching between: - WPS and browser - WPS and Playlist Catalogue - WPS and playlist - WPS and Settings/System/Plugins * when accessing Track Info or when displaying bookmarks using the context menu on the WPS * when switching from QuickScreen to Shortcuts Menu 2) The playlist viewer activity was pushed & popped redundantly by playlist_view. ---- NB: Behavior has remained unchanged in all instances of the code where pop_current_activity() has been replaced by pop_current_activity(ACTIVITY_REFRESH_NOW). Change-Id: I56b517b8c9dba823a9fed3a3f558d7469dcea9fd
Diffstat (limited to 'apps/menus')
-rw-r--r--apps/menus/playlist_menu.c2
-rw-r--r--apps/menus/time_menu.c2
2 files changed, 3 insertions, 1 deletions
diff --git a/apps/menus/playlist_menu.c b/apps/menus/playlist_menu.c
index 89c93edc2e..981ec74798 100644
--- a/apps/menus/playlist_menu.c
+++ b/apps/menus/playlist_menu.c
@@ -138,6 +138,8 @@ int save_playlist_screen(struct playlist_info* playlist)
138static int playlist_view_(void) 138static int playlist_view_(void)
139{ 139{
140 playlist_viewer_ex(NULL, NULL); 140 playlist_viewer_ex(NULL, NULL);
141 FOR_NB_SCREENS(i) /* Playlist Viewer defers skin updates when popping its activity */
142 skin_update(CUSTOM_STATUSBAR, i, SKIN_REFRESH_ALL);
141 return 0; 143 return 0;
142} 144}
143MENUITEM_FUNCTION(create_playlist_item, 0, ID2P(LANG_CREATE_PLAYLIST), 145MENUITEM_FUNCTION(create_playlist_item, 0, ID2P(LANG_CREATE_PLAYLIST),
diff --git a/apps/menus/time_menu.c b/apps/menus/time_menu.c
index e37e2b5637..b44d47ff8b 100644
--- a/apps/menus/time_menu.c
+++ b/apps/menus/time_menu.c
@@ -304,7 +304,7 @@ int time_screen(void* ignored)
304#endif 304#endif
305 305
306 ret = do_menu(&time_menu, NULL, menu, false); 306 ret = do_menu(&time_menu, NULL, menu, false);
307 pop_current_activity(); 307 pop_current_activity(ACTIVITY_REFRESH_NOW);
308 /* see comments above in the button callback */ 308 /* see comments above in the button callback */
309 if (!menu_was_pressed && ret == GO_TO_PREVIOUS) 309 if (!menu_was_pressed && ret == GO_TO_PREVIOUS)
310 return 0; 310 return 0;