diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2022-09-19 12:48:15 +0100 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2022-10-05 11:22:55 -0400 |
commit | d5a081cbd1b871baf4e5d2c276fbabbc30c7994b (patch) | |
tree | aac3c9377be8433ad15c4ca2a733d3a7c81aad97 /apps/menu.c | |
parent | ff378deb69951a53b866f3d3c6ee13022e520436 (diff) | |
download | rockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.tar.gz rockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.zip |
gui: Remove "enum list_wrap" from list action functions
Removing the "list_wrap" argument is actually pretty easy.
In practice, almost all lists are using LIST_WRAP_UNLESS_HELD
behavior so we can make that the default. A couple of lists
disable wraparound with LIST_WRAP_OFF; this is now achieved
by setting the list "wraparound" flag to false when setting
up the list. LIST_WRAP_ON was unused and is of questionable
value, so it has been removed entirely.
This makes list wraparound behavior a property of the list,
controlled solely by the "wraparound" flag. The result is a
simpler list API and implementation, without changing the
behavior of any lists.
Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a
Diffstat (limited to 'apps/menu.c')
-rw-r--r-- | apps/menu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/menu.c b/apps/menu.c index fd3c041e36..85dac8a214 100644 --- a/apps/menu.c +++ b/apps/menu.c | |||
@@ -450,7 +450,7 @@ int do_menu(const struct menu_item_ex *start_menu, int *start_selected, | |||
450 | action = new_action; | 450 | action = new_action; |
451 | } | 451 | } |
452 | 452 | ||
453 | if (LIKELY(gui_synclist_do_button(&lists, &action, LIST_WRAP_UNLESS_HELD))) | 453 | if (LIKELY(gui_synclist_do_button(&lists, &action))) |
454 | continue; | 454 | continue; |
455 | #ifdef HAVE_QUICKSCREEN | 455 | #ifdef HAVE_QUICKSCREEN |
456 | else if (action == ACTION_STD_QUICKSCREEN) | 456 | else if (action == ACTION_STD_QUICKSCREEN) |