summaryrefslogtreecommitdiff
path: root/apps/lang
diff options
context:
space:
mode:
authorPaul Sauro <olsroparadise@proton.me>2024-09-07 13:55:45 +0200
committerWilliam Wilgus <me.theuser@yahoo.com>2024-09-09 18:21:38 -0400
commitf7db73097a30a9cd5ec6415fcc197749ee1bc559 (patch)
tree116924fcc95a4400ead473ce69652192a405eff7 /apps/lang
parenta7cfee640dcaa00e3717bd2ef4bd54489f491960 (diff)
downloadrockbox-f7db73097a30a9cd5ec6415fcc197749ee1bc559.tar.gz
rockbox-f7db73097a30a9cd5ec6415fcc197749ee1bc559.zip
Playlist viewer: Add new options to allow formatting using tags
Offer new options to show elegantly your entries in any playlist/dynamic playlist viewer. This is especially important if you dual boot an iPod with Stock OS and want to sync with iTunes; with this very popular setup, file names are obfuscated which results in any Rockbox playlist viewer difficult to enjoy, and it was a long standing issue reported by several Rockbox users over the years. The only way to show the title was to open a contextual menu on each song to get infos about the selected song, which is a very long and anti-ergonomic process to understand what is on your current playlist/randomized playlist. The idea of this patch is to provide new alternatives that the user can select. I personally selected the Title & Album view which provides excellent readability. This patch was built with performance in mind using lazy loading to load one by one the tags then cache a string and use the little cache as much as possible to make scrolling in the same area as smooth as possible. Performance remains very acceptable even on an iPod 4G with its original hard drive. Using a real compact flash with my iPod Mini 2G reduces the latency even more. Those new options are disabled by default because they impact noticeably the scrolling performance and are less relevant if your files are decently properly named. Unfortunately, the search feature in a playlist will need to continue to use the raw filename because reading the tags for a whole playlist is a performance disaster. This works decently while viewing just because I made a code that load those one by one as much as possible. I focused also on testing that the opening of the playlist viewer UI remained fast, and loading one by one with lazy loading allows to get very little overhead in this regard. Change-Id: I00d9c802e29f8372447813b035bbae207a016467
Diffstat (limited to 'apps/lang')
-rw-r--r--apps/lang/english.lang28
-rw-r--r--apps/lang/francais.lang28
2 files changed, 56 insertions, 0 deletions
diff --git a/apps/lang/english.lang b/apps/lang/english.lang
index c518d3573c..1ee1ffac0f 100644
--- a/apps/lang/english.lang
+++ b/apps/lang/english.lang
@@ -2032,6 +2032,34 @@
2032 </voice> 2032 </voice>
2033</phrase> 2033</phrase>
2034<phrase> 2034<phrase>
2035 id: LANG_DISPLAY_TITLEALBUM_FROMTAGS
2036 desc: track display options
2037 user: core
2038 <source>
2039 *: "Title & Album from ID3 tags"
2040 </source>
2041 <dest>
2042 *: "Title & Album from ID3 tags"
2043 </dest>
2044 <voice>
2045 *: "Title and Album from tags"
2046 </voice>
2047</phrase>
2048<phrase>
2049 id: LANG_DISPLAY_TITLE_FROMTAGS
2050 desc: track display options
2051 user: core
2052 <source>
2053 *: "Title from ID3 tags"
2054 </source>
2055 <dest>
2056 *: "Title from ID3 tags"
2057 </dest>
2058 <voice>
2059 *: "Title from tags"
2060 </voice>
2061</phrase>
2062<phrase>
2035 id: LANG_BUILDING_DATABASE 2063 id: LANG_BUILDING_DATABASE
2036 desc: splash database building progress 2064 desc: splash database building progress
2037 user: core 2065 user: core
diff --git a/apps/lang/francais.lang b/apps/lang/francais.lang
index 518b48fb96..b8883d4997 100644
--- a/apps/lang/francais.lang
+++ b/apps/lang/francais.lang
@@ -2005,6 +2005,34 @@
2005 </voice> 2005 </voice>
2006</phrase> 2006</phrase>
2007<phrase> 2007<phrase>
2008 id: LANG_DISPLAY_TITLEALBUM_FROMTAGS
2009 desc: track display options
2010 user: core
2011 <source>
2012 *: "Title & Album from ID3 tags"
2013 </source>
2014 <dest>
2015 *: "Titre & Album depuis les tags ID3"
2016 </dest>
2017 <voice>
2018 *: "Titre et Album depuis les tags"
2019 </voice>
2020</phrase>
2021<phrase>
2022 id: LANG_DISPLAY_TITLE_FROMTAGS
2023 desc: track display options
2024 user: core
2025 <source>
2026 *: "Title from ID3 tags"
2027 </source>
2028 <dest>
2029 *: "Titre depuis les tags ID3"
2030 </dest>
2031 <voice>
2032 *: "Titre depuis les tags"
2033 </voice>
2034</phrase>
2035<phrase>
2008 id: LANG_BUILDING_DATABASE 2036 id: LANG_BUILDING_DATABASE
2009 desc: splash database building progress 2037 desc: splash database building progress
2010 user: core 2038 user: core