summaryrefslogtreecommitdiff
path: root/apps/keymaps/keymap-zenxfi2.c
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2023-03-17 23:43:39 +0000
committerAidan MacDonald <amachronic@protonmail.com>2023-03-18 17:47:19 +0000
commita0a59ab61019bc06d85f4db34a74a3b53f15f3b4 (patch)
treececfd61c4e08b9e30903abed7cb790b1cd36b855 /apps/keymaps/keymap-zenxfi2.c
parent0c29d1788eae87eb1cba71a70b1facd6ff995eb2 (diff)
downloadrockbox-a0a59ab61019bc06d85f4db34a74a3b53f15f3b4.tar.gz
rockbox-a0a59ab61019bc06d85f4db34a74a3b53f15f3b4.zip
Fix locked context fallthrough
Enabling locked actions for all softlock targets accidentally broke keylock on touchscreens because the generic touchscreen keymap was missed. Trying to lookup CONTEXT_WPS|CONTEXT_LOCKED returned the mapping for CONTEXT_STD because the locked version wasn't explicitly handled. But on almost all cases, a context's keymap does not change when the screen is locked. It makes more sense to mask out the locked flag and only check for it where needed. Change-Id: I65cda2de82950d272d4394fd772286699e7c3779
Diffstat (limited to 'apps/keymaps/keymap-zenxfi2.c')
-rw-r--r--apps/keymaps/keymap-zenxfi2.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/apps/keymaps/keymap-zenxfi2.c b/apps/keymaps/keymap-zenxfi2.c
index 43e65ce5d7..ba25592246 100644
--- a/apps/keymaps/keymap-zenxfi2.c
+++ b/apps/keymaps/keymap-zenxfi2.c
@@ -137,18 +137,15 @@ static const struct button_mapping button_context_radio[] = {
137 137
138const struct button_mapping* target_get_context_mapping(int context) 138const struct button_mapping* target_get_context_mapping(int context)
139{ 139{
140 switch (context) 140 switch (context & ~CONTEXT_LOCKED)
141 { 141 {
142 case CONTEXT_STD | CONTEXT_LOCKED:
143 case CONTEXT_STD: 142 case CONTEXT_STD:
144 return button_context_standard; 143 return button_context_standard;
145 case CONTEXT_WPS | CONTEXT_LOCKED:
146 case CONTEXT_WPS: 144 case CONTEXT_WPS:
147 return button_context_wps; 145 return button_context_wps;
148 146
149 case CONTEXT_LIST: 147 case CONTEXT_LIST:
150 return button_context_list; 148 return button_context_list;
151 case CONTEXT_MAINMENU | CONTEXT_LOCKED:
152 case CONTEXT_MAINMENU: 149 case CONTEXT_MAINMENU:
153 case CONTEXT_TREE: 150 case CONTEXT_TREE:
154 if (global_settings.hold_lr_for_scroll_in_list) 151 if (global_settings.hold_lr_for_scroll_in_list)