summaryrefslogtreecommitdiff
path: root/apps/keymaps/keymap-erosq.c
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2023-03-17 23:43:39 +0000
committerAidan MacDonald <amachronic@protonmail.com>2023-03-18 17:47:19 +0000
commita0a59ab61019bc06d85f4db34a74a3b53f15f3b4 (patch)
treececfd61c4e08b9e30903abed7cb790b1cd36b855 /apps/keymaps/keymap-erosq.c
parent0c29d1788eae87eb1cba71a70b1facd6ff995eb2 (diff)
downloadrockbox-a0a59ab61019bc06d85f4db34a74a3b53f15f3b4.tar.gz
rockbox-a0a59ab61019bc06d85f4db34a74a3b53f15f3b4.zip
Fix locked context fallthrough
Enabling locked actions for all softlock targets accidentally broke keylock on touchscreens because the generic touchscreen keymap was missed. Trying to lookup CONTEXT_WPS|CONTEXT_LOCKED returned the mapping for CONTEXT_STD because the locked version wasn't explicitly handled. But on almost all cases, a context's keymap does not change when the screen is locked. It makes more sense to mask out the locked flag and only check for it where needed. Change-Id: I65cda2de82950d272d4394fd772286699e7c3779
Diffstat (limited to 'apps/keymaps/keymap-erosq.c')
-rw-r--r--apps/keymaps/keymap-erosq.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/apps/keymaps/keymap-erosq.c b/apps/keymaps/keymap-erosq.c
index 7e2643a318..054da96201 100644
--- a/apps/keymaps/keymap-erosq.c
+++ b/apps/keymaps/keymap-erosq.c
@@ -194,17 +194,14 @@ static const struct button_mapping button_context_bmark[] = {
194/* get_context_mapping returns a pointer to one of the above defined arrays depending on the context */ 194/* get_context_mapping returns a pointer to one of the above defined arrays depending on the context */
195const struct button_mapping* get_context_mapping(int context) 195const struct button_mapping* get_context_mapping(int context)
196{ 196{
197 switch (context) 197 switch (context & ~CONTEXT_LOCKED)
198 { 198 {
199 case CONTEXT_STD | CONTEXT_LOCKED:
200 case CONTEXT_STD: 199 case CONTEXT_STD:
201 return button_context_standard; 200 return button_context_standard;
202 201
203 case CONTEXT_WPS | CONTEXT_LOCKED:
204 case CONTEXT_WPS: 202 case CONTEXT_WPS:
205 return button_context_wps; 203 return button_context_wps;
206 204
207 case CONTEXT_MAINMENU | CONTEXT_LOCKED:
208 case CONTEXT_MAINMENU: 205 case CONTEXT_MAINMENU:
209 return button_context_mainmenu; 206 return button_context_mainmenu;
210 207