split the theme settings apply() sutff out of settings_apply(). this should fix splashes not being loc'ed, statusbar over the splash (fixed in sim, not on my mini2g though), and the supposed boot time slowdown.

What this also does is remove a bunch of unnecessary settings_Apply()'s from the ipod accessory code, and causes all non-skin settings to get applied each time (this includes font and langs which we wernt doing to stop disk access)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24922 a1c6a512-1295-4272-9138-f99709370657

1 files changed, 0 insertions, 6 deletions

diff --git a/apps/iap.c b/apps/iap.c
index 741ff9fb0c..3075db90fa 100644
--- a/apps/iap.c
+++ b/apps/iap.c
@@ -420,7 +420,6 @@ void iap_handlepkt(void)
                 {
                     global_settings.playlist_shuffle = 1;
                     settings_save();
-                    settings_apply(false);
                     if (audio_status() & AUDIO_STATUS_PLAY)
                         playlist_randomise(NULL, current_tick, true);
                 }
@@ -428,7 +427,6 @@ void iap_handlepkt(void)
                 {
                     global_settings.playlist_shuffle = 0;
                     settings_save();
-                    settings_apply(false);
                     if (audio_status() & AUDIO_STATUS_PLAY)
                         playlist_sort(NULL, true);
                 }
@@ -451,7 +449,6 @@ void iap_handlepkt(void)
                         global_settings.repeat_mode = REPEAT_ALL;
 
                 settings_save();
-                settings_apply(false);
                 if (audio_status() & AUDIO_STATUS_PLAY)
                 audio_flush_and_reload_tracks();
             }
@@ -716,7 +713,6 @@ void iap_handlepkt(void)
                 {
                     global_settings.playlist_shuffle = 1;
                     settings_save();
-                    settings_apply(false);
                     if (audio_status() & AUDIO_STATUS_PLAY)
                         playlist_randomise(NULL, current_tick, true);
                 }
@@ -724,7 +720,6 @@ void iap_handlepkt(void)
                 {
                     global_settings.playlist_shuffle = 0;
                     settings_save();
-                    settings_apply(false);
                     if (audio_status() & AUDIO_STATUS_PLAY)
                         playlist_sort(NULL, true);
                 }
@@ -762,7 +757,6 @@ void iap_handlepkt(void)
                 if (oldmode != global_settings.repeat_mode)
                 {
                     settings_save();
-                    settings_apply(false);
                     if (audio_status() & AUDIO_STATUS_PLAY)
                         audio_flush_and_reload_tracks();
                 }