diff options
author | William Wilgus <wilgus.william@gmail.com> | 2020-10-28 22:55:27 -0400 |
---|---|---|
committer | William Wilgus <wilgus.william@gmail.com> | 2020-10-28 22:55:27 -0400 |
commit | c5c17fa7995c62267a1695e58841bd17b9fb2099 (patch) | |
tree | 006286eed2293005a06ac6477546ed225069beb9 /apps/gui | |
parent | c7fb319151ba60a086c75e8de819315eda57ae55 (diff) | |
download | rockbox-c5c17fa7995c62267a1695e58841bd17b9fb2099.tar.gz rockbox-c5c17fa7995c62267a1695e58841bd17b9fb2099.zip |
Fix display regression from c85d8e2
Basically setting a null buffer is valid but it must be selected
into a screen to initialize to the default buffer
I wrongly assumed screen type wouldn't matter but since I decided to
reference backdrops directly to the default buffer
(since they are saved as an offset from what it later assumes to be the
default framebuffer)
SCREEN_MAIN/SCREEN_REMOTE are not longer optional
Change-Id: I8a8afbbe1e3ed0bfe6abd40ce287638e9fc6da60
Diffstat (limited to 'apps/gui')
-rw-r--r-- | apps/gui/skin_engine/skin_backdrops.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/apps/gui/skin_engine/skin_backdrops.c b/apps/gui/skin_engine/skin_backdrops.c index 20010efa26..41de1e1f76 100644 --- a/apps/gui/skin_engine/skin_backdrops.c +++ b/apps/gui/skin_engine/skin_backdrops.c | |||
@@ -210,8 +210,15 @@ void skin_backdrop_set_buffer(int backdrop_id, struct skin_viewport *svp) | |||
210 | return; | 210 | return; |
211 | else if (backdrop_id < 0) | 211 | else if (backdrop_id < 0) |
212 | { | 212 | { |
213 | /* SCREEN_MAIN is ok here screen only matters if passed VP is NULL */ | 213 | #if 1 |
214 | screens[SCREEN_MAIN].viewport_set_buffer(&svp->vp, NULL); /*Default*/ | 214 | /* ensure the current vp has been removed so it has to be reselected */ |
215 | screens[SCREEN_MAIN].set_viewport_ex(NULL, 0); | ||
216 | # if defined(HAVE_REMOTE_LCD) | ||
217 | screens[SCREEN_REMOTE].set_viewport_ex(NULL, 0); | ||
218 | # endif | ||
219 | #endif | ||
220 | /* WARNING: vp-> buffer is invaid till viewport is set to a screen */ | ||
221 | svp->vp.buffer = NULL; /*Default*/ | ||
215 | return; | 222 | return; |
216 | } | 223 | } |
217 | 224 | ||