diff options
author | William Wilgus <wilgus.william@gmail.com> | 2022-04-17 10:36:33 -0400 |
---|---|---|
committer | William Wilgus <me.theuser@yahoo.com> | 2022-04-17 10:59:56 -0400 |
commit | c4156b1909175cd74154fa4217be053c1180ae9c (patch) | |
tree | 0511ee767f000a6b9fe0cc9c06503b8a4b28f647 /apps/gui | |
parent | 6703f43f5cc6c6d2f4983aaafd4bcfd582b133cf (diff) | |
download | rockbox-c4156b1909175cd74154fa4217be053c1180ae9c.tar.gz rockbox-c4156b1909175cd74154fa4217be053c1180ae9c.zip |
viewports, set flags to VP_DEFAULT_FLAGS
flags were getting un-initialized memory
it really didn't matter with the flags getting initialized
anyway
But once I added a new flag that didn't explicitly
set or clear the flag at init well here we are
set flags to VP_DEFAULT_FLAGS in viewport_set_defaults()
add the flags variable to the default vp's set to 0
(it was already initialized to 0 by bss, make it explicit)
Change-Id: I3a9a062455b4cf66d2b8c70fdf05402a5c0c091c
Diffstat (limited to 'apps/gui')
-rw-r--r-- | apps/gui/viewport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/gui/viewport.c b/apps/gui/viewport.c index 3dd8bca979..9f9cb186f5 100644 --- a/apps/gui/viewport.c +++ b/apps/gui/viewport.c | |||
@@ -332,7 +332,7 @@ void viewport_set_defaults(struct viewport *vp, | |||
332 | const enum screen_type screen) | 332 | const enum screen_type screen) |
333 | { | 333 | { |
334 | vp->buffer = NULL; /* use default frame_buffer */ | 334 | vp->buffer = NULL; /* use default frame_buffer */ |
335 | 335 | vp->flags = VP_DEFAULT_FLAGS; | |
336 | #if !defined(__PCTOOL__) | 336 | #if !defined(__PCTOOL__) |
337 | struct viewport *sbs_area = NULL; | 337 | struct viewport *sbs_area = NULL; |
338 | if (!is_theme_enabled(screen)) | 338 | if (!is_theme_enabled(screen)) |