misc.c open_pathfmt caller supplied buffer

Amachronic raised concern about open() blocking causing a static buf
to get overwritten in multiple calls its prudent to just have the caller
supply the buffer to minimize stack issues later

Change-Id: Iae27c7d063adb1a65688f920f6aa5c395fa5694a

1 files changed, 3 insertions, 1 deletions

diff --git a/apps/gui/icon.c b/apps/gui/icon.c
index 2c09f88852..9deb1a0c65 100644
--- a/apps/gui/icon.c
+++ b/apps/gui/icon.c
@@ -182,7 +182,9 @@ static void load_icons(const char* filename, enum Iconset iconset,
     ic->handle = 0;
     if (filename[0] && filename[0] != '-')
     {
-        fd = open_pathfmt(O_RDONLY, ICON_DIR "/%s.bmp", filename);
+        char fname[MAX_PATH];
+        fd = open_pathfmt(fname, sizeof(fname), O_RDONLY,
+                          ICON_DIR "/%s.bmp", filename);
         if (fd < 0)
             return;
         buf_size = read_bmp_fd(fd, &ic->bmp, 0,