summaryrefslogtreecommitdiff
path: root/apps/gui
diff options
context:
space:
mode:
authorJonathan Gordon <rockbox@jdgordon.info>2011-11-19 13:46:25 +0000
committerJonathan Gordon <rockbox@jdgordon.info>2011-11-19 13:46:25 +0000
commit1252d0d54084a17255d2fad57a462cd15479561b (patch)
treeabb5e6a523fde1a44b2d41c5bf564e25286d4dc5 /apps/gui
parent852b68c74aab63915ba9c9c7378cf33e3277e6bb (diff)
downloadrockbox-1252d0d54084a17255d2fad57a462cd15479561b.tar.gz
rockbox-1252d0d54084a17255d2fad57a462cd15479561b.zip
Get rid of a really annoying #ifdef line to check if backdrop support should be enabled
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@31027 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/gui')
-rw-r--r--apps/gui/skin_engine/skin_backdrops.c3
-rw-r--r--apps/gui/skin_engine/skin_engine.c4
-rw-r--r--apps/gui/skin_engine/skin_parser.c4
-rw-r--r--apps/gui/skin_engine/wps_internals.h2
-rw-r--r--apps/gui/viewport.c2
-rw-r--r--apps/gui/wps.c4
6 files changed, 9 insertions, 10 deletions
diff --git a/apps/gui/skin_engine/skin_backdrops.c b/apps/gui/skin_engine/skin_backdrops.c
index 4663a8756f..0b67125bbf 100644
--- a/apps/gui/skin_engine/skin_backdrops.c
+++ b/apps/gui/skin_engine/skin_backdrops.c
@@ -28,8 +28,7 @@
28#include "wps_internals.h" 28#include "wps_internals.h"
29#include "skin_engine.h" 29#include "skin_engine.h"
30 30
31#if !defined(__PCTOOL__) && \ 31#if !defined(__PCTOOL__) && defined(HAVE_BACKDROP_IMAGE)
32 ((LCD_DEPTH > 1) || (defined(HAVE_REMOTE_LCD) && (LCD_REMOTE_DEPTH > 1)))
33 32
34#define NB_BDROPS SKINNABLE_SCREENS_COUNT*NB_SCREENS 33#define NB_BDROPS SKINNABLE_SCREENS_COUNT*NB_SCREENS
35static struct skin_backdrop { 34static struct skin_backdrop {
diff --git a/apps/gui/skin_engine/skin_engine.c b/apps/gui/skin_engine/skin_engine.c
index 75862faab0..c6791cac09 100644
--- a/apps/gui/skin_engine/skin_engine.c
+++ b/apps/gui/skin_engine/skin_engine.c
@@ -133,11 +133,11 @@ void settings_apply_skins(void)
133 FOR_NB_SCREENS(j) 133 FOR_NB_SCREENS(j)
134 skin_get_gwps(i, j); 134 skin_get_gwps(i, j);
135 } 135 }
136#if LCD_DEPTH > 1 || defined(HAVE_REMOTE_LCD) && LCD_REMOTE_DEPTH > 1 136#ifdef HAVE_BACKDROP_IMAGE
137 skin_backdrops_preload(); /* should maybe check the retval here... */ 137 skin_backdrops_preload(); /* should maybe check the retval here... */
138#endif 138#endif
139 viewportmanager_theme_changed(THEME_STATUSBAR); 139 viewportmanager_theme_changed(THEME_STATUSBAR);
140#if LCD_DEPTH > 1 || defined(HAVE_REMOTE_LCD) && LCD_REMOTE_DEPTH > 1 140#ifdef HAVE_BACKDROP_IMAGE
141 FOR_NB_SCREENS(i) 141 FOR_NB_SCREENS(i)
142 skin_backdrop_show(sb_get_backdrop(i)); 142 skin_backdrop_show(sb_get_backdrop(i));
143#endif 143#endif
diff --git a/apps/gui/skin_engine/skin_parser.c b/apps/gui/skin_engine/skin_parser.c
index 33561bfed4..ad10689107 100644
--- a/apps/gui/skin_engine/skin_parser.c
+++ b/apps/gui/skin_engine/skin_parser.c
@@ -1537,7 +1537,7 @@ static void skin_data_reset(struct wps_data *wps_data)
1537 wps_data->images = INVALID_OFFSET; 1537 wps_data->images = INVALID_OFFSET;
1538#endif 1538#endif
1539 wps_data->tree = INVALID_OFFSET; 1539 wps_data->tree = INVALID_OFFSET;
1540#if LCD_DEPTH > 1 || defined(HAVE_REMOTE_LCD) && LCD_REMOTE_DEPTH > 1 1540#ifdef HAVE_BACKDROP_IMAGE
1541 if (wps_data->backdrop_id >= 0) 1541 if (wps_data->backdrop_id >= 0)
1542 skin_backdrop_unload(wps_data->backdrop_id); 1542 skin_backdrop_unload(wps_data->backdrop_id);
1543 backdrop_filename = NULL; 1543 backdrop_filename = NULL;
@@ -2202,7 +2202,7 @@ bool skin_data_load(enum screen_type screen, struct wps_data *wps_data,
2202 } 2202 }
2203 skin_buffer = (void *)(((unsigned long)skin_buffer + 3) & ~3); 2203 skin_buffer = (void *)(((unsigned long)skin_buffer + 3) & ~3);
2204 buffersize -= 3; 2204 buffersize -= 3;
2205#if LCD_DEPTH > 1 || defined(HAVE_REMOTE_LCD) && LCD_REMOTE_DEPTH > 1 2205#ifdef HAVE_BACKDROP_IMAGE
2206 backdrop_filename = "-"; 2206 backdrop_filename = "-";
2207 wps_data->backdrop_id = -1; 2207 wps_data->backdrop_id = -1;
2208#endif 2208#endif
diff --git a/apps/gui/skin_engine/wps_internals.h b/apps/gui/skin_engine/wps_internals.h
index 65a063592f..9c3fa1b5bc 100644
--- a/apps/gui/skin_engine/wps_internals.h
+++ b/apps/gui/skin_engine/wps_internals.h
@@ -325,7 +325,7 @@ struct wps_data
325 OFFSETTYPE(int *) font_ids; 325 OFFSETTYPE(int *) font_ids;
326 int font_count; 326 int font_count;
327#endif 327#endif
328#if LCD_DEPTH > 1 || defined(HAVE_REMOTE_LCD) && LCD_REMOTE_DEPTH > 1 328#ifdef HAVE_BACKDROP_IMAGE
329 int backdrop_id; 329 int backdrop_id;
330#endif 330#endif
331 331
diff --git a/apps/gui/viewport.c b/apps/gui/viewport.c
index 940f7f9cfa..a55ccc3221 100644
--- a/apps/gui/viewport.c
+++ b/apps/gui/viewport.c
@@ -117,7 +117,7 @@ static void toggle_theme(enum screen_type screen, bool force)
117 bool first_boot = theme_stack_top[screen] == 0; 117 bool first_boot = theme_stack_top[screen] == 0;
118 /* remove the left overs from the previous screen. 118 /* remove the left overs from the previous screen.
119 * could cause a tiny flicker. Redo your screen code if that happens */ 119 * could cause a tiny flicker. Redo your screen code if that happens */
120#if LCD_DEPTH > 1 || defined(HAVE_REMOTE_LCD) && LCD_REMOTE_DEPTH > 1 120#ifdef HAVE_BACKDROP_IMAGE
121 skin_backdrop_show(sb_get_backdrop(screen)); 121 skin_backdrop_show(sb_get_backdrop(screen));
122#endif 122#endif
123 if (LIKELY(after_boot[screen]) && (!was_enabled[screen] || force)) 123 if (LIKELY(after_boot[screen]) && (!was_enabled[screen] || force))
diff --git a/apps/gui/wps.c b/apps/gui/wps.c
index 97c945d0e8..284aa57a3e 100644
--- a/apps/gui/wps.c
+++ b/apps/gui/wps.c
@@ -631,7 +631,7 @@ static void gwps_leave_wps(void)
631 FOR_NB_SCREENS(i) 631 FOR_NB_SCREENS(i)
632 { 632 {
633 skin_get_gwps(WPS, i)->display->stop_scroll(); 633 skin_get_gwps(WPS, i)->display->stop_scroll();
634#if LCD_DEPTH > 1 || defined(HAVE_REMOTE_LCD) && LCD_REMOTE_DEPTH > 1 634#ifdef HAVE_BACKDROP_IMAGE
635 skin_backdrop_show(sb_get_backdrop(i)); 635 skin_backdrop_show(sb_get_backdrop(i));
636#endif 636#endif
637 viewportmanager_theme_undo(i, skin_has_sbs(i, skin_get_gwps(WPS, i)->data)); 637 viewportmanager_theme_undo(i, skin_has_sbs(i, skin_get_gwps(WPS, i)->data));
@@ -678,7 +678,7 @@ static void gwps_enter_wps(void)
678 } 678 }
679#endif 679#endif
680 /* make the backdrop actually take effect */ 680 /* make the backdrop actually take effect */
681#if LCD_DEPTH > 1 || defined(HAVE_REMOTE_LCD) && LCD_REMOTE_DEPTH > 1 681#ifdef HAVE_BACKDROP_IMAGE
682 skin_backdrop_show(gwps->data->backdrop_id); 682 skin_backdrop_show(gwps->data->backdrop_id);
683#endif 683#endif
684 display->clear_display(); 684 display->clear_display();