summaryrefslogtreecommitdiff
path: root/apps/gui/skin_engine/skin_parser.c
diff options
context:
space:
mode:
authorThomas Martitz <kugel@rockbox.org>2009-11-04 07:14:02 +0000
committerThomas Martitz <kugel@rockbox.org>2009-11-04 07:14:02 +0000
commitc0635ba6c9abc22bbb87a6b426d61d4c915f7131 (patch)
treee5589565f013ed144dc0f7bed93831b46d684a04 /apps/gui/skin_engine/skin_parser.c
parent6750d65f791f19097ce740cfbe12a873a915a897 (diff)
downloadrockbox-c0635ba6c9abc22bbb87a6b426d61d4c915f7131.tar.gz
rockbox-c0635ba6c9abc22bbb87a6b426d61d4c915f7131.zip
Remove wps_data.remote_wps. It's redundant with the new global curr_screen.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23512 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/gui/skin_engine/skin_parser.c')
-rw-r--r--apps/gui/skin_engine/skin_parser.c19
1 files changed, 3 insertions, 16 deletions
diff --git a/apps/gui/skin_engine/skin_parser.c b/apps/gui/skin_engine/skin_parser.c
index 3585907182..d06494d908 100644
--- a/apps/gui/skin_engine/skin_parser.c
+++ b/apps/gui/skin_engine/skin_parser.c
@@ -696,12 +696,6 @@ static int parse_viewport(const char *wps_bufptr,
696 (void)token; /* Kill warnings */ 696 (void)token; /* Kill warnings */
697 const char *ptr = wps_bufptr; 697 const char *ptr = wps_bufptr;
698 698
699 const int screen =
700#ifdef HAVE_REMOTE_LCD
701 wps_data->remote_wps ? SCREEN_REMOTE :
702#endif
703 SCREEN_MAIN;
704
705 struct skin_viewport *skin_vp = skin_buffer_alloc(sizeof(struct skin_viewport)); 699 struct skin_viewport *skin_vp = skin_buffer_alloc(sizeof(struct skin_viewport));
706 700
707 /* check for the optional letter to signify its a hideable viewport */ 701 /* check for the optional letter to signify its a hideable viewport */
@@ -749,7 +743,7 @@ static int parse_viewport(const char *wps_bufptr,
749 struct viewport *vp = &skin_vp->vp; 743 struct viewport *vp = &skin_vp->vp;
750 /* format: %V|x|y|width|height|font|fg_pattern|bg_pattern| */ 744 /* format: %V|x|y|width|height|font|fg_pattern|bg_pattern| */
751 745
752 if (!(ptr = viewport_parse_viewport(vp, screen, ptr, '|'))) 746 if (!(ptr = viewport_parse_viewport(vp, curr_screen, ptr, '|')))
753 return WPS_ERROR_INVALID_PARAM; 747 return WPS_ERROR_INVALID_PARAM;
754 748
755 vp->flags &= ~VP_FLAG_ALIGN_RIGHT; /* ignore right-to-left languages */ 749 vp->flags &= ~VP_FLAG_ALIGN_RIGHT; /* ignore right-to-left languages */
@@ -1732,7 +1726,6 @@ static bool wps_parse(struct wps_data *data, const char *wps_bufptr, bool debug)
1732 * initial setup of wps_data; does reset everything 1726 * initial setup of wps_data; does reset everything
1733 * except fields which need to survive, i.e. 1727 * except fields which need to survive, i.e.
1734 * 1728 *
1735 * wps_data->remote_wps
1736 **/ 1729 **/
1737void skin_data_reset(struct wps_data *wps_data) 1730void skin_data_reset(struct wps_data *wps_data)
1738{ 1731{
@@ -1784,7 +1777,7 @@ static bool load_skin_bmp(struct wps_data *wps_data, struct bitmap *bitmap, char
1784 /* load the image */ 1777 /* load the image */
1785 int format; 1778 int format;
1786#ifdef HAVE_REMOTE_LCD 1779#ifdef HAVE_REMOTE_LCD
1787 if (wps_data->remote_wps) 1780 if (curr_screen == SCREEN_REMOTE)
1788 format = FORMAT_ANY|FORMAT_REMOTE; 1781 format = FORMAT_ANY|FORMAT_REMOTE;
1789 else 1782 else
1790#endif 1783#endif
@@ -1839,16 +1832,10 @@ static bool load_skin_bitmaps(struct wps_data *wps_data, char *bmpdir)
1839#if (LCD_DEPTH > 1) || (defined(HAVE_REMOTE_LCD) && (LCD_REMOTE_DEPTH > 1)) 1832#if (LCD_DEPTH > 1) || (defined(HAVE_REMOTE_LCD) && (LCD_REMOTE_DEPTH > 1))
1840 if (bmp_names[BACKDROP_BMP]) 1833 if (bmp_names[BACKDROP_BMP])
1841 { 1834 {
1842 int screen = SCREEN_MAIN;
1843 char img_path[MAX_PATH]; 1835 char img_path[MAX_PATH];
1844 get_image_filename(bmp_names[BACKDROP_BMP], bmpdir, 1836 get_image_filename(bmp_names[BACKDROP_BMP], bmpdir,
1845 img_path, sizeof(img_path)); 1837 img_path, sizeof(img_path));
1846#if defined(HAVE_REMOTE_LCD) 1838 screens[curr_screen].backdrop_load(BACKDROP_SKIN_WPS, img_path);
1847 /* We only need to check LCD type if there is a remote LCD */
1848 if (wps_data->remote_wps)
1849 screen = SCREEN_REMOTE;
1850#endif
1851 screens[screen].backdrop_load(BACKDROP_SKIN_WPS, img_path);
1852 } 1839 }
1853#endif /* has backdrop support */ 1840#endif /* has backdrop support */
1854 1841