diff options
author | Christian Soffke <christian.soffke@gmail.com> | 2022-11-27 01:15:14 +0100 |
---|---|---|
committer | Christian Soffke <christian.soffke@gmail.com> | 2022-12-11 11:50:33 +0100 |
commit | dfd9c10589d25a966c7e2e4dedab57c59a1987fd (patch) | |
tree | f65fcbefd97eff19ec3605aa1dfc161ad4221da6 /apps/gui/quickscreen.c | |
parent | 90d1ac044857781c4885da8cbfde62ece344fce3 (diff) | |
download | rockbox-dfd9c10589d25a966c7e2e4dedab57c59a1987fd.tar.gz rockbox-dfd9c10589d25a966c7e2e4dedab57c59a1987fd.zip |
Eliminate skin updates in between activities
1) Adds way to pop activity without refreshing the skin at
the same time.
Activities are sometimes popped in immediate succession,
or one activity is popped before another one is pushed right
away. This can lead to the UI appearing glitchy, due to an
activity only appearing for a split-second, which is especially
noticeable with complex skins that change the dimensions
of the UI viewport depending on the current activity
To fix this, prevent superfluous skin updates
* when switching between:
- WPS and browser
- WPS and Playlist Catalogue
- WPS and playlist
- WPS and Settings/System/Plugins
* when accessing Track Info or when displaying
bookmarks using the context menu on the WPS
* when switching from QuickScreen to Shortcuts Menu
2) The playlist viewer activity was pushed & popped
redundantly by playlist_view.
----
NB:
Behavior has remained unchanged in all instances of the
code where pop_current_activity() has been replaced by
pop_current_activity(ACTIVITY_REFRESH_NOW).
Change-Id: I56b517b8c9dba823a9fed3a3f558d7469dcea9fd
Diffstat (limited to 'apps/gui/quickscreen.c')
-rw-r--r-- | apps/gui/quickscreen.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/apps/gui/quickscreen.c b/apps/gui/quickscreen.c index 141eb1a16b..1f32dca544 100644 --- a/apps/gui/quickscreen.c +++ b/apps/gui/quickscreen.c | |||
@@ -406,10 +406,13 @@ static int gui_syncquickscreen_run(struct gui_quickscreen * qs, int button_enter | |||
406 | { /* stop scrolling before exiting */ | 406 | { /* stop scrolling before exiting */ |
407 | for (int j = 0; j < QUICKSCREEN_ITEM_COUNT; j++) | 407 | for (int j = 0; j < QUICKSCREEN_ITEM_COUNT; j++) |
408 | screens[i].scroll_stop_viewport(&vps[i][j]); | 408 | screens[i].scroll_stop_viewport(&vps[i][j]); |
409 | viewportmanager_theme_undo(i, true); | 409 | viewportmanager_theme_undo(i, !(ret & QUICKSCREEN_GOTO_SHORTCUTS_MENU)); |
410 | } | 410 | } |
411 | 411 | ||
412 | pop_current_activity(); | 412 | if (ret & QUICKSCREEN_GOTO_SHORTCUTS_MENU) /* Eliminate flashing of parent during */ |
413 | pop_current_activity(ACTIVITY_REFRESH_DEFERRED); /* transition to Shortcuts */ | ||
414 | else | ||
415 | pop_current_activity(ACTIVITY_REFRESH_NOW); | ||
413 | 416 | ||
414 | return ret; | 417 | return ret; |
415 | } | 418 | } |